Skip to content

Fix unstable test TestBroadcastEventHandlers #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamdickmeiss merged 2 commits into from
Jul 20, 2026
Merged

Fix unstable test TestBroadcastEventHandlers #670

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d31501e
Fix unstable test iTestBroadcastEventHandlers
adamdickmeiss Jul 19, 2026
6c5d203
Merge branch 'main' into fix-test-TestBroadcastEventHandlers
adamdickmeiss Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion broker/test/events/eventbus_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func TestMultipleEventHandlers(t *testing.T) {
noPools := 3
noEvents := 2
receivedAr := make([][]events.Event, noPools)
var receivedMu sync.Mutex
var normalCreated atomic.Int32
ctx, cancel := context.WithCancel(context.Background())
for i := 0; i < noPools; i++ {
Expand All @@ -84,6 +85,8 @@ func TestMultipleEventHandlers(t *testing.T) {
eventBus := app.CreateEventBus(eventRepo)

eventBus.HandleEventCreated(events.EventNameRequestReceived, events.HandlerRoleConsumer, func(ctx common.ExtendedContext, event events.Event) {
receivedMu.Lock()
defer receivedMu.Unlock()
receivedAr[i] = append(receivedAr[i], event)
})
Comment thread
adamdickmeiss marked this conversation as resolved.
eventBus.HandleEventCreated(events.EventNameConfirmRequesterMsg, events.HandlerRoleConsumer, func(ctx common.ExtendedContext, event events.Event) {
Expand All @@ -98,6 +101,8 @@ func TestMultipleEventHandlers(t *testing.T) {

var requestReceived1 []events.Event
eventBus.HandleEventCreated(events.EventNameRequestReceived, events.HandlerRoleConsumer, func(ctx common.ExtendedContext, event events.Event) {
receivedMu.Lock()
defer receivedMu.Unlock()
requestReceived1 = append(requestReceived1, event)
})

Expand All @@ -108,6 +113,8 @@ func TestMultipleEventHandlers(t *testing.T) {
}

if !test.WaitForPredicateToBeTrue(func() bool {
receivedMu.Lock()
defer receivedMu.Unlock()
total := len(requestReceived1)
for i := 0; i < noPools; i++ {
total += len(receivedAr[i])
Expand All @@ -116,12 +123,16 @@ func TestMultipleEventHandlers(t *testing.T) {
}) {
t.Error("Expected to have some events")
}
receivedMu.Lock()
total := len(requestReceived1)
for i := 0; i < noPools; i++ {
total += len(receivedAr[i])
}
receivedMu.Unlock()
assert.Equal(t, noEvents, total, "Total number of events should match the number of created tasks")
if total != noEvents {
receivedMu.Lock()
defer receivedMu.Unlock()
for e := range requestReceived1 {
t.Logf("Request event %d: %s", e, requestReceived1[e].ID)
}
Expand All @@ -137,6 +148,7 @@ func TestBroadcastEventHandlers(t *testing.T) {
noPools := 3
noEvents := 2
receivedAr := make([][]events.Event, noPools)
var receivedMu sync.Mutex
var normalCreated atomic.Int32
ctx, cancel := context.WithCancel(context.Background())
for i := 0; i < noPools; i++ {
Expand All @@ -148,6 +160,8 @@ func TestBroadcastEventHandlers(t *testing.T) {
eventBus := app.CreateEventBus(eventRepo)

eventBus.HandleEventCreated(events.EventNameConfirmRequesterMsg, events.HandlerRoleObserver, func(ctx common.ExtendedContext, event events.Event) {
receivedMu.Lock()
defer receivedMu.Unlock()
receivedAr[i] = append(receivedAr[i], event)
})
Comment thread
adamdickmeiss marked this conversation as resolved.
eventBus.HandleEventCreated(events.EventNameConfirmRequesterMsg, events.HandlerRoleConsumer, func(ctx common.ExtendedContext, event events.Event) {
Expand All @@ -162,6 +176,8 @@ func TestBroadcastEventHandlers(t *testing.T) {

var requestReceived1 []events.Event
eventBus.HandleEventCreated(events.EventNameConfirmRequesterMsg, events.HandlerRoleObserver, func(ctx common.ExtendedContext, event events.Event) {
receivedMu.Lock()
defer receivedMu.Unlock()
requestReceived1 = append(requestReceived1, event)
})
eventBus.HandleEventCreated(events.EventNameConfirmRequesterMsg, events.HandlerRoleConsumer, func(ctx common.ExtendedContext, event events.Event) {
Expand All @@ -175,6 +191,8 @@ func TestBroadcastEventHandlers(t *testing.T) {
}

if !test.WaitForPredicateToBeTrue(func() bool {
receivedMu.Lock()
defer receivedMu.Unlock()
total := len(requestReceived1)
for i := 0; i < noPools; i++ {
total += len(receivedAr[i])
Expand All @@ -183,13 +201,17 @@ func TestBroadcastEventHandlers(t *testing.T) {
}) {
t.Error("Expected to have some events")
}
receivedMu.Lock()
total := len(requestReceived1)
for i := 0; i < noPools; i++ {
total += len(receivedAr[i])
}
receivedMu.Unlock()
assert.Equal(t, noEvents*(noPools+1), total, "Total number of events should match the number of created tasks")
assert.Equal(t, int32(0), normalCreated.Load(), "broadcast-created signals should not invoke normal created handlers")
if total != noEvents {
if total != noEvents*(noPools+1) {
receivedMu.Lock()
defer receivedMu.Unlock()
for e := range requestReceived1 {
t.Logf("Request event %d: %s", e, requestReceived1[e].ID)
}
Expand Down
Loading