Expect retry-conditional event to WILL_SUPPLY - #672
Merged
Conversation
JanisSaldabols
approved these changes
Jul 21, 2026
adamdickmeiss
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for receiving the supplier retry-conditional (ISO18626 RetryPossible) message event when a borrower-side patron request is already in WILL_SUPPLY, allowing the request to move into the retry workflow rather than rejecting the status change.
Changes:
- Extend the requester-side
WILL_SUPPLYstate to accept theretry-conditionalevent and transition toRETRY_PENDING. - Regenerate/update the compiled state model JSON to reflect the YAML change.
- Add a unit test asserting the
WILL_SUPPLY→RETRY_PENDINGtransition onretry-conditional.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| misc/state-models.yaml | Adds retry-conditional as an allowed event in WILL_SUPPLY (requester side), transitioning to RETRY_PENDING. |
| broker/patron_request/service/statemodels/state-models.json | Updates the generated state model artifact to include the new event mapping. |
| broker/patron_request/service/action_mapping_test.go | Adds a test covering the new event transition from borrower WILL_SUPPLY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.