Cleanup API links - #673
Merged
Merged
Conversation
JanisSaldabols
approved these changes
Jul 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the broker API index (“/”) to remove non-actionable top-level links and replace the generic patron-requests link with two concrete, usable links for borrowing and lending requests.
Changes:
- Remove
eventsLinkandlocatedSuppliersLinkfrom the API index response. - Replace
patronRequestsLinkwithborrowingRequestsLinkandlendingRequestsLink(including the requiredsidequery parameter). - Update OpenAPI schema and index handler tests to match the new index response shape.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| broker/test/api/api-handler_test.go | Updates index response assertions to expect borrowing/lending patron request links instead of events/located suppliers. |
| broker/oapi/open-api.yaml | Updates the Index.links schema: removes old link fields and requires the new borrowing/lending link fields. |
| broker/api/api-handler.go | Adjusts the index handler to emit the new borrowing/lending links and drop the removed ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.