CROSSLINK-267 Add local supply - #679
Merged
Merged
Conversation
JanisSaldabols
commented
Jul 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Local Supply” path to the patron request state model so requests that can be fulfilled locally can be handled via dedicated actions/events, while keeping the ISO18626 workflow/state-machine consistent.
Changes:
- Added a new
LOCAL_SUPPLYrequester state (withfill-locally,cancel,cannot-supply-locallyactions) to the returnables state model. - Introduced a new supplier message event
expect-to-supply-localand mapped it in message handling when the supplying agency is the same as the requester. - Extended built-in capabilities and tests to include the new state/action/event and added action-service support for
fill-locally.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| misc/state-models.yaml | Adds LOCAL_SUPPLY state and expect-to-supply-local event to the source state model. |
| broker/patron_request/service/statemodels/state-models.json | Keeps the generated state-model JSON in sync with the YAML changes. |
| broker/patron_request/service/statemodel_test.go | Asserts capabilities include LOCAL_SUPPLY and that the returnables model contains the new state. |
| broker/patron_request/service/statemodel_capabilities.go | Adds constants/capabilities for the new state, actions, and message event. |
| broker/patron_request/service/message-handler.go | Maps ExpectToSupply to a dedicated local event when supplier == requester. |
| broker/patron_request/service/action.go | Adds borrower-side handlers for local supply actions, including fillLocallyBorrowingRequest. |
| broker/patron_request/service/action_test.go | Adds test coverage for invoking fill-locally and extends LMS adapter mock to supply locations. |
| broker/patron_request/service/action_mapping_test.go | Ensures action mapping includes the new LOCAL_SUPPLY borrower actions. |
jakub-id
reviewed
Jul 23, 2026
JanisSaldabols
force-pushed
the
CROSSLINK-267
branch
from
July 23, 2026 13:45
67637e7 to
4f0477a
Compare
jakub-id
reviewed
Jul 23, 2026
jakub-id
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.