Modhaadm 141 vertx5 - #139
Merged
Merged
Conversation
Initial changes required for upgrading to vertx 5, including applying the validating handler used in vertx lib 4 though applying non-validating for post/put of plain text and XML, since validation of those seems unsupported by vertx/openapi so far .
-- can't seem to use ValidatedRequest.getPathParameters (?), using HttpServerRequest.getParam instead -- more tests (and fixing some bugs that this found) -- inline schemas in OpenAPI yaml file (cannot include external references anymore)
Pass custom packaged AdminRequest to service methods instead of raw vertx and routing context objects
-- for the tests in HarvesterIntegrationTest.java
- adapt cql to sql to refactored request handlers - use non-validating handler for previous job log - test coverage of date queries for logs - bug-fix date queries for logs - reduce logging
# Conflicts: # src/main/java/org/folio/harvesteradmin/service/HarvestAdminService.java
…onTest.java Co-authored-by: Adam Dickmeiss <adam@indexdata.dk>
Co-authored-by: Adam Dickmeiss <adam@indexdata.dk>
Co-authored-by: Adam Dickmeiss <adam@indexdata.dk>
Co-authored-by: Adam Dickmeiss <adam@indexdata.dk>
-- work around spurious test error in GH during mvn build task when cleaning up harvester records after test.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODHAADM-141 localindices test coverage
-- work around spurious test error in GH only during mvn build task when cleaning up localindices records after test.