fix socket path trust check failing on root-owned directories; improv…#648
Merged
fix socket path trust check failing on root-owned directories; improv…#648
Conversation
…e error message Add GID 0 (root group) to the trusted GID list, mirroring the existing implicit trust of UID 0. This fixes the issue where directories like /tmp owned by root:root with group-writable + sticky bit permissions were incorrectly flagged as untrusted. Fixes #603. Also make the OIDC_EPERM error message include the actual path that failed the trust check, giving users actionable diagnostic information instead of just 'socket path location is not trustworthy'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e error message
Add GID 0 (root group) to the trusted GID list, mirroring the existing implicit trust of UID 0. This fixes the issue where directories like /tmp owned by root:root with group-writable + sticky bit permissions were incorrectly flagged as untrusted. Fixes #603.
Also make the OIDC_EPERM error message include the actual path that failed the trust check, giving users actionable diagnostic information instead of just 'socket path location is not trustworthy'.