Skip to content

fix(processors.parser): Handle metrics without inner timestamp correctly#19074

Merged
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:processors_parser_issue_16331
Jun 25, 2026
Merged

fix(processors.parser): Handle metrics without inner timestamp correctly#19074
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:processors_parser_issue_16331

Conversation

@srebhan

@srebhan srebhan commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

This PR uses the newly introduced ParserTimeFuncPlugin plugin interface to make sure the inner parser returns a zero timestamp in cases where the data-to-parse does not provide time information.

Checklist

Related issues

resolves #16331

@telegraf-tiger telegraf-tiger Bot added fix pr to fix corresponding bug plugin/processor labels Jun 10, 2026
@srebhan srebhan self-assigned this Jun 10, 2026
@srebhan srebhan added plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jun 10, 2026
@srebhan srebhan assigned skartikey and unassigned srebhan Jun 11, 2026

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Looks good, The only remaining part is updating the README. The override-with-timestamp description still reads "override the timestamp with the one of the latest parsed metric," with no "if it exists" caveat.

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks!

@telegraf-tiger

Copy link
Copy Markdown
Contributor

@skartikey skartikey merged commit 4007573 into influxdata:master Jun 25, 2026
27 checks passed
@skartikey skartikey deleted the processors_parser_issue_16331 branch June 25, 2026 11:32
skartikey pushed a commit that referenced this pull request Jun 29, 2026
@skartikey skartikey added this to the v1.39.1 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/parser 1. Request for new parser plugins 2. Issues/PRs that are related to parser plugins plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Processors.parser and data_format="prometheus" and timestamps

2 participants