Skip to content

fix(build): Create tarballs correctly#19077

Merged
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:fix
Jun 23, 2026
Merged

fix(build): Create tarballs correctly#19077
skartikey merged 2 commits into
influxdata:masterfrom
srebhan:fix

Conversation

@srebhan

@srebhan srebhan commented Jun 11, 2026

Copy link
Copy Markdown
Member

Summary

This PR implements the suggestion in #19075 to fix

tar: .: Cannot utime: Operation not permitted
tar: .: Cannot change mode to rwxr-xr-t: Operation not permitted
tar: Exiting with failure status due to previous errors

errors when untaring Telegraf packages.

Checklist

Related issues

resolves #19075

@telegraf-tiger telegraf-tiger Bot added the fix pr to fix corresponding bug label Jun 11, 2026
@srebhan srebhan added area/packaging ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jun 11, 2026
@skartikey

Copy link
Copy Markdown
Contributor

@srebhan The Makefile change is correct, but it changes the leading path-component count in the darwin tarballs and scripts/mac-signing.sh extracts them with --strip-components=2 and then signs Resources/usr/bin/telegraf. With the new layout the binary extracts to Resources/bin/telegraf, so the codesign step would fail. package-sign-mac only runs in the release/nightly workflow, so PR CI doesn't exercise it. Suggest changing mac-signing.sh:107 to --strip-components=1 in this PR.

@telegraf-tiger

Copy link
Copy Markdown
Contributor

@skartikey skartikey assigned srebhan and unassigned skartikey Jun 22, 2026
@skartikey

Copy link
Copy Markdown
Contributor

Hey @srebhan, quick summary:

  • Makefile: .tar.gz now archives the package dir itself ($(notdir $(DESTDIR))) instead of its contents (.). Archiving . is what triggered the tar: .: Cannot utime / Cannot change mode errors on extraction.
  • scripts/mac-signing.sh: --strip-components 2 -> 1 to match the new layout (one fewer leading path component).

Tested on my Mac, tarball extracts cleanly. Ready to go.

@srebhan srebhan assigned skartikey and unassigned srebhan Jun 23, 2026

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks!

@skartikey skartikey merged commit a41d39b into influxdata:master Jun 23, 2026
27 checks passed
@skartikey skartikey deleted the fix branch June 23, 2026 09:43
skartikey added a commit that referenced this pull request Jun 29, 2026
Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com>
(cherry picked from commit a41d39b)
@skartikey skartikey added this to the v1.39.1 milestone Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/packaging fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telegraf Release .tar.gz files aren't correctly tarred

2 participants