Skip to content

feat(inputs.ping): Add interface argument support for Windows (#17071)#19116

Merged
skartikey merged 1 commit into
influxdata:masterfrom
mbhs-josh:17071
Jun 25, 2026
Merged

feat(inputs.ping): Add interface argument support for Windows (#17071)#19116
skartikey merged 1 commit into
influxdata:masterfrom
mbhs-josh:17071

Conversation

@mbhs-josh

Copy link
Copy Markdown
Contributor

Summary

Add support for the interface argument on Windows as discussed in #17071

Please note, I am not familiar with Go and although this seemed to be a simple change I don't know how to build or test it.

Checklist

Related issues

resolves #17071

@telegraf-tiger

Copy link
Copy Markdown
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger Bot added area/ping feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 16, 2026
@telegraf-tiger

Copy link
Copy Markdown
Contributor

@mbhs-josh

Copy link
Copy Markdown
Contributor Author

!signed-cla

@srebhan srebhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @mbhs-josh! Looks all good.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 23, 2026

@skartikey skartikey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbhs-josh Thanks for the contribution!

@skartikey skartikey merged commit 012ed27 into influxdata:master Jun 25, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ping feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[inputs.ping] Windows - Exec method - interface property does not work

3 participants