feat(inputs.ping): Add interface argument support for Windows (#17071)#19116
Merged
Conversation
Contributor
|
Thanks so much for the pull request! |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Contributor
Author
|
!signed-cla |
srebhan
approved these changes
Jun 23, 2026
srebhan
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution @mbhs-josh! Looks all good.
skartikey
approved these changes
Jun 25, 2026
skartikey
left a comment
Contributor
There was a problem hiding this comment.
@mbhs-josh Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the interface argument on Windows as discussed in #17071
Please note, I am not familiar with Go and although this seemed to be a simple change I don't know how to build or test it.
Checklist
Related issues
resolves #17071