Skip to content

fix(inputs.redfish): Extend testcases for gofish lib change#19163

Open
inhinias wants to merge 5 commits into
influxdata:masterfrom
inhinias:rf_gf_tests_adaption
Open

fix(inputs.redfish): Extend testcases for gofish lib change#19163
inhinias wants to merge 5 commits into
influxdata:masterfrom
inhinias:rf_gf_tests_adaption

Conversation

@inhinias

Copy link
Copy Markdown
Contributor

Summary

Since the plan is to move to the gofish lib we extend the tests to work with them in a later pr.
Because gofish expects to move from the top of the api to lower nodes, every testcase requires
/redfish/v1/ & /redfish/v1/Systems/ to be present.

Also gofish does no trigger an invalid Response with a trailing "{". Therefore its moved to the start of the data.

Datacenter is supposed to be under the Postal address: tags["datacenter"] = chassis.Location.PostalAddress.DataCenter but its nowhere to be found in the standard. See page 35.

It should be considered if the "room" tag should be changed too since PostalAddress is deprecated.
This pr removes just the datacenter tag from the tests but not the actual program. That test would fail and is therefor skipped. Please inform me on how to handle this case for the "moving to gofish" pr.

Also i already added the testdata for the subsystems that will be added as a feature later.

Checklist

Related issues

Related to: #18963

@telegraf-tiger telegraf-tiger Bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 26, 2026
@inhinias inhinias closed this Jun 26, 2026
@inhinias inhinias reopened this Jun 26, 2026
@inhinias inhinias marked this pull request as ready for review June 26, 2026 12:53
@telegraf-tiger

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant