fix(inputs.redfish): Extend testcases for gofish lib change#19163
Open
inhinias wants to merge 5 commits into
Open
fix(inputs.redfish): Extend testcases for gofish lib change#19163inhinias wants to merge 5 commits into
inhinias wants to merge 5 commits into
Conversation
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the plan is to move to the gofish lib we extend the tests to work with them in a later pr.
Because gofish expects to move from the top of the api to lower nodes, every testcase requires
/redfish/v1/ & /redfish/v1/Systems/ to be present.
Also gofish does no trigger an invalid Response with a trailing "{". Therefore its moved to the start of the data.
Datacenter is supposed to be under the Postal address: tags["datacenter"] = chassis.Location.PostalAddress.DataCenter but its nowhere to be found in the standard. See page 35.
It should be considered if the "room" tag should be changed too since PostalAddress is deprecated.
This pr removes just the datacenter tag from the tests but not the actual program. That test would fail and is therefor skipped. Please inform me on how to handle this case for the "moving to gofish" pr.
Also i already added the testdata for the subsystems that will be added as a feature later.
Checklist
Related issues
Related to: #18963