Fix: add proper backwards-compatible Kotlin support - #42
Merged
Merged
Conversation
dirkluijk
commented
Sep 15, 2021
lpandzic
approved these changes
Sep 15, 2021
lpandzic
reviewed
Sep 15, 2021
| <dependency> | ||
| <groupId>org.jetbrains.kotlin</groupId> | ||
| <artifactId>kotlin-reflect</artifactId> | ||
| <optional>true</optional> |
Member
There was a problem hiding this comment.
PS I suspect that this can't be optional due to the fact that kotlin discovery code path is invoked every time, even in non kotlin environments?
Contributor
Author
There was a problem hiding this comment.
In Spring Data Common it's optional, I think because we first invoke KotlinReflectionUtils. isSupportedKotlinClass from Spring, which - I think - doesn't rely on kotkin-reflect itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
In #37, I added support for Kotlin classes by using
PreferredConstructorDiscovererfrom Spring Data Common.However, Spring prefers no-argument constructors over other constructors, which doesn't seem to be compatible with QueryDSL. Therefore, the original implementation preferred the constructor with the most parameters instead.
To be compatible with both QueryDSL and Kotlin data classes, I made a custom
PreferredConstructorDiscovererwhich is inspired by the way Spring Data Common supports Kotlin, but still uses the custom logic that was implemented before.