fix: include propagation problems in tag policy pass/fail check [PIP-456] - #23
Merged
Merged
Conversation
…456] Resources with all required tags present but misconfigured tag propagation (e.g. ECS service with propagate_tags=null) were incorrectly classified as passing. The pass/fail condition now also checks for propagation problems.
drewblas
force-pushed
the
fix/pip-456-propagation-problems-ignored
branch
from
March 31, 2026 13:01
d94c065 to
62eed9f
Compare
liamcervante
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws_ecs_servicewithpropagate_tags=null) were silently classified as passing a tagging policylen(resourceResult.propagationProblems) == 0to the pass/fail condition inevaluateResourceAgainstPolicyTest plan
TestEvaluateAgainstResources_PropagationProblemsupdated and passingTestEvaluateAgainstResources_ECSServicePropagationProblemsregression test passinggo test ./...passesgo vet ./...clean