Skip to content

feat: relationships and fields needed by FinOps tree-policies - #62

Merged
liamg merged 1 commit into
mainfrom
add-missing-tree-fields
May 13, 2026
Merged

feat: relationships and fields needed by FinOps tree-policies#62
liamg merged 1 commit into
mainfrom
add-missing-tree-fields

Conversation

@liamg

@liamg liamg commented May 13, 2026

Copy link
Copy Markdown
Member

Summary

Adds the missing pieces that several azurerm + GKE tree-policies need to run:

  • azure/compute: AvailabilitySetID on (Linux|Windows|)VirtualMachine, so policies can detect VMs in availability sets.
  • azure/compute: ManagedDisk.Relationships.{Linux,Windows,}VirtualMachine populated via PostProcess from DiskAttachment rows and from inline OSDisk/StorageOSDisk/StorageDataDisks references on legacy VMs.
  • google/container: Cluster.Relationships.DefaultNodePool populated from the inline default node pool.
  • aws/ecs: drop unused TaskDefinitionRelationships.Services back-link to avoid a ServiceTaskDefinition pointer cycle; policies that need the reverse direction scan Services at runtime.

Test plan

  • Existing go-proto unit tests still pass
  • Verified downstream in `infracost/providers` e2e tree-policies suite (all 64 previously-failing tests now pass after this + matching parser changes)

Adds the missing pieces that several azurerm + GKE tree-policies need to run:

- azure/compute: AvailabilitySetID on (Linux|Windows|)VirtualMachine, so
  policies can detect VMs in availability sets.
- azure/compute: ManagedDisk.Relationships.{Linux,Windows,}VirtualMachine
  populated via PostProcess from DiskAttachment rows and from inline
  OSDisk/StorageOSDisk/StorageDataDisks references on legacy VMs.
- google/container: Cluster.Relationships.DefaultNodePool populated from
  the inline default node pool.
- aws/ecs: drop unused TaskDefinitionRelationships.Services back-link to
  avoid a Service<->TaskDefinition pointer cycle; policies that need
  the reverse direction scan Services at runtime.
@liamg
liamg merged commit 221d29c into main May 13, 2026
3 checks passed
@liamg
liamg deleted the add-missing-tree-fields branch May 13, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants