Fix sklearn API breakage when using search models with groups#286
Open
detrin wants to merge 1 commit into
Open
Fix sklearn API breakage when using search models with groups#286detrin wants to merge 1 commit into
detrin wants to merge 1 commit into
Conversation
detrin
force-pushed
the
fix/sklearn-groups-routing
branch
from
387f3df to
36f5c90
Compare
Reverts the search model .fit() call to not pass groups directly, which breaks on sklearn 1.7+ with metadata routing enabled.
detrin
force-pushed
the
fix/sklearn-groups-routing
branch
2 times, most recently
from
c708064 to
66be0d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #278.
PR #275 added
groups=groupsto the search model's.fit()call (line 457). This breaks on sklearn 1.7+ where metadata routing is enabled by default -RandomizedSearchCV.fitandGridSearchCV.fitrejectgroupsas an unexpected argument.The fix reverts that call to
clone(self.model).fit(current_X, self.y). Thegroupsparameter is only needed for the outer CV splits (lines 475/489), not for the inner hyperparameter search which runs its own internal CV.Tested with sklearn 1.6.1 + metadata routing enabled manually, and all 25 feature_elimination tests pass.