bump up ios Inji ovp & vci client library version#2514
Conversation
Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
👮 Files not reviewed due to content moderation or server errors (2)
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (3 warnings)
✅ Passed checks (2 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: one or more packages not found in the registry. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@shared/openID4VP/OpenID4VPHelper.ts`:
- Around line 95-98: The OpenID4VPHelper signing flow is allowing an undefined
signature to be cast into VPTokenSigningResult, which downstream iOS parsing
cannot handle. Update the signData path in OpenID4VPHelper so the
default/unsupported algorithm branch throws an explicit error instead of falling
through, and ensure the return object only uses a real signature for signedData.
Apply the same fix to the related signing result path referenced in the second
affected block so unsupported algorithms never produce a VPTokenSigningResult
with a missing String value.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 66a07190-f09b-4eab-b20b-65d9f119cda8
📒 Files selected for processing (4)
ios/Inji.xcworkspace/xcshareddata/swiftpm/Package.resolvedmachines/openID4VP/openID4VPMachine.tsshared/hooks/useOvpErrorModal.tsshared/openID4VP/OpenID4VPHelper.ts
Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
5053c37 to
c8e4bf6
Compare
Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
Fixes: #2482
Summary by CodeRabbit
Bug Fixes
Chores