Skip to content

bump up ios Inji ovp & vci client library version#2514

Merged
Prafulrakhade merged 3 commits into
inji:developfrom
tw-mosip:update-ovp-lib-enc-support
Jul 2, 2026
Merged

bump up ios Inji ovp & vci client library version#2514
Prafulrakhade merged 3 commits into
inji:developfrom
tw-mosip:update-ovp-lib-enc-support

Conversation

@KiruthikaJeyashankar

@KiruthikaJeyashankar KiruthikaJeyashankar commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Fixes: #2482

Summary by CodeRabbit

  • Bug Fixes

    • Improved QR/error handling so reset actions now return users to the previous step instead of leaving the app stuck on the error screen.
    • Refined error mapping so some client-related failures follow the correct fallback handling.
    • Fixed signing behavior for certain RSA-based flows to better support successful request processing.
  • Chores

    • Updated the bundled package reference to a newer recorded build.

Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82a3991d-0587-4ecb-b179-fb8be42072e7

📥 Commits

Reviewing files that changed from the base of the PR and between 5053c37 and 454f320.

📒 Files selected for processing (2)
  • ios/Inji.xcworkspace/xcshareddata/swiftpm/Package.resolved
  • shared/openID4VP/OpenID4VPHelper.ts
👮 Files not reviewed due to content moderation or server errors (2)
  • shared/openID4VP/OpenID4VPHelper.ts
  • ios/Inji.xcworkspace/xcshareddata/swiftpm/Package.resolved

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (3 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description only links an issue and omits the required Description, Issue ticket number/link, and Screenshots sections. Fill in the template sections with a change summary, the issue number/link, and screenshots or a note that none are needed.
Linked Issues check ⚠️ Warning The changes update the iOS package and signing/error handling, but they do not implement verifier metadata-based JWE encryption for direct_post.jwt or iar_post.jwt. Add OpenID4VP response encryption support using verifier alg/enc/jwks metadata, and ensure both success and error responses are encrypted and decryptable.
Out of Scope Changes check ⚠️ Warning State-machine resets, error-modal branching, and RSA signing changes are unrelated to the encryption objectives in issue #2482. Remove or split unrelated behavior changes into separate PRs unless they are necessary for the OpenID4VP encryption fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the iOS OVP version bump, though it underplays the additional signing and state/error-handling changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed: one or more packages not found in the registry.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@shared/openID4VP/OpenID4VPHelper.ts`:
- Around line 95-98: The OpenID4VPHelper signing flow is allowing an undefined
signature to be cast into VPTokenSigningResult, which downstream iOS parsing
cannot handle. Update the signData path in OpenID4VPHelper so the
default/unsupported algorithm branch throws an explicit error instead of falling
through, and ensure the return object only uses a real signature for signedData.
Apply the same fix to the related signing result path referenced in the second
affected block so unsupported algorithms never produce a VPTokenSigningResult
with a missing String value.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66a07190-f09b-4eab-b20b-65d9f119cda8

📥 Commits

Reviewing files that changed from the base of the PR and between 9de5163 and 5053c37.

📒 Files selected for processing (4)
  • ios/Inji.xcworkspace/xcshareddata/swiftpm/Package.resolved
  • machines/openID4VP/openID4VPMachine.ts
  • shared/hooks/useOvpErrorModal.ts
  • shared/openID4VP/OpenID4VPHelper.ts

Comment thread shared/openID4VP/OpenID4VPHelper.ts
Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
@KiruthikaJeyashankar KiruthikaJeyashankar force-pushed the update-ovp-lib-enc-support branch from 5053c37 to c8e4bf6 Compare July 2, 2026 10:51
Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
@KiruthikaJeyashankar KiruthikaJeyashankar changed the title bump up ios Inji ovp library version bump up ios Inji ovp & vci client library version Jul 2, 2026
@Prafulrakhade Prafulrakhade merged commit fc32319 into inji:develop Jul 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants