Skip to content

Dev networks - DO NOT MERGE#1688

Draft
jpraynaud wants to merge 3 commits into
mainfrom
jpraynaud/1687-optimize-cardano-tx-proof
Draft

Dev networks - DO NOT MERGE#1688
jpraynaud wants to merge 3 commits into
mainfrom
jpraynaud/1687-optimize-cardano-tx-proof

Conversation

@jpraynaud

@jpraynaud jpraynaud commented May 16, 2024

Copy link
Copy Markdown
Member

Important

This PR is for tests only and must not be merged

@jpraynaud jpraynaud added the prototype 🛠️ Prototype/PoC of a feature label May 16, 2024
@jpraynaud jpraynaud self-assigned this May 16, 2024
@github-actions

github-actions Bot commented May 16, 2024

Copy link
Copy Markdown

Test Results

     5 files  ± 0     206 suites  ±0   56m 31s ⏱️ - 1h 55m 40s
 3 186 tests  - 72   3 186 ✅  - 72  0 💤 ±0  0 ❌ ±0 
10 697 runs   - 81  10 697 ✅  - 81  0 💤 ±0  0 ❌ ±0 

Results for commit 9164588. ± Comparison against base commit d1d2dae.

This pull request removes 72 tests.
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_out_of_bounds
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::index_too_large_for_circuit_range
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::indices_not_increasing
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_merkle_path_mismatch
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_swap_keep_merkle_path
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::leaf_wrong_verification_key
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_corrupt_sibling
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_flip_position
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_long
mithril-stm ‑ circuits::halo2::tests::golden::cases::negative::slow::merkle_path_length_short
…

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview May 16, 2024 16:38 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 16, 2024 16:38 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 2ed9469 to 0f5a44a Compare May 17, 2024 11:28
@jpraynaud jpraynaud temporarily deployed to testing-preview May 17, 2024 11:35 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 17, 2024 11:35 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-mainnet May 17, 2024 13:03 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch 3 times, most recently from 41ed35b to e0f47e1 Compare May 21, 2024 18:52
@jpraynaud jpraynaud temporarily deployed to testing-preview May 21, 2024 19:00 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 21, 2024 19:00 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from e0f47e1 to 1cd5b3a Compare May 22, 2024 07:31
@jpraynaud jpraynaud temporarily deployed to testing-preview May 22, 2024 07:38 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 22, 2024 07:38 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-mainnet May 22, 2024 10:29 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch 4 times, most recently from a0e498c to 039003e Compare May 23, 2024 08:12
@jpraynaud jpraynaud temporarily deployed to testing-preview May 23, 2024 08:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 23, 2024 08:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 039003e to fecabad Compare May 23, 2024 08:49
@jpraynaud jpraynaud temporarily deployed to testing-preview May 23, 2024 08:56 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 23, 2024 08:56 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from fecabad to df9737a Compare May 23, 2024 09:58
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 26470f2 to f45cd5a Compare May 24, 2024 14:54
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 24, 2024 15:01 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview May 24, 2024 15:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 24, 2024 15:20 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-mainnet May 24, 2024 15:49 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch 2 times, most recently from c8df10f to 4066c06 Compare May 30, 2024 14:22
@jpraynaud jpraynaud temporarily deployed to testing-preview May 30, 2024 14:31 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet May 30, 2024 14:31 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-mainnet May 30, 2024 15:08 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 4066c06 to 11e53c5 Compare June 5, 2024 16:46
@jpraynaud jpraynaud temporarily deployed to testing-preview June 5, 2024 16:54 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet June 5, 2024 16:54 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-mainnet June 5, 2024 17:03 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1687-optimize-cardano-tx-proof branch from 11e53c5 to 5bd3c65 Compare June 11, 2024 13:58
@jpraynaud jpraynaud temporarily deployed to testing-preview June 11, 2024 14:06 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet June 11, 2024 14:06 — with GitHub Actions Inactive
Comment thread mithril-common/src/chain_reader/pallas_chain_reader.rs Fixed
Comment thread mithril-common/src/chain_reader/pallas_chain_reader.rs Fixed
Comment thread mithril-aggregator/src/services/signature_processor.rs Fixed
Comment thread mithril-aggregator/src/services/signature_processor.rs Fixed
Comment thread mithril-common/src/crypto_helper/cardano/kes/signer_with_key.rs Fixed
Comment thread mithril-common/src/crypto_helper/cardano/kes/signer_with_key.rs Fixed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to be an experiment to improve/inspect GitHub Actions E2E log grouping and retry behavior for dev networks, by adjusting E2E logging, CI retry/matrix behavior, and adding timing diagnostics during chain import.

Changes:

  • Re-enable GitHub Actions log grouping (::group:: / ::endgroup::) in the E2E test lab utilities.
  • Enable the allow_skip_signer_certification feature by default in mithril-common.
  • Add debug timing + counters around parsing/storing/rollback in the Cardano chain importer, and expand E2E CI attempts/logging.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
mithril-test-lab/mithril-end-to-end/src/utils/formatting.rs Re-enabled GitHub Actions log grouping markers around E2E logs.
mithril-common/Cargo.toml Changed default feature set to include allow_skip_signer_certification.
internal/cardano-node/mithril-cardano-node-chain/src/chain_importer/blocks_and_transactions_importer.rs Added debug logs for parse/store/rollback elapsed time and counts.
.github/workflows/ci.yml Increased E2E matrix repetitions and added retry step outputs / extra group logging.

Comment thread mithril-common/Cargo.toml

[features]
default = ["num-integer-backend"]
default = ["num-integer-backend", "allow_skip_signer_certification"]
Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml
Comment on lines +454 to +456
echo "::group::Artificial group after e2e"
echo "This is a test"
echo "::endgroup::"
Comment thread mithril-common/Cargo.toml

[features]
default = ["num-integer-backend"]
default = ["num-integer-backend", "allow_skip_signer_certification"]
jpraynaud and others added 3 commits June 19, 2026 19:00
Re-activate as-is in order to see if there was some changes GH sides
that solved the previous problem: logs of a retried run were lost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

prototype 🛠️ Prototype/PoC of a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants