refactor(stm): applying final comments of PR #3348

[damrobi]

Content

This PR includes some small fixes from the leftover comments of PR #3348, mainly:

• Better context for the IvcCircuitError::CertificateProofRejected error
• Better handling of the GenesisMessagePreimage in tests
• Name change for the AncillaryProverData variant

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested

Comments

Issue(s)

Relates to #3141

[github-actions]

Test Results

     5 files  ± 0     206 suites  ±0   1h 19m 18s ⏱️ - 1h 15m 37s
 3 261 tests  - 18   3 261 ✅  - 18  0 💤 ±0  0 ❌ ±0 
10 924 runs   - 18  10 924 ✅  - 18  0 💤 ±0  0 ❌ ±0 

Results for commit f2852c7. ± Comparison against base commit 5d25797.

This pull request removes 18 tests.

mithril-stm ‑ proof_system::halo2_snark::clerk::tests::slow::selection_distributes_fairly_across_index_range
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::different_parameters_prove_and_verify_fails
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::fails_with_empty_signatures
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::fails_with_insufficient_signatures
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::golden::golden_conversion
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::midnight_vk_wrapper_to_from_bytes
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::non_deterministic_proofs_verify
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::prepare_and_check_fails_with_random_bytes
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::prepare_and_check_fails_with_wrong_message
mithril-stm ‑ proof_system::halo2_snark::proof::tests::slow::produces_valid_snark_proof
…

♻️ This comment has been updated with latest results.

[jpraynaud]

LGTM