Connector Healthcheck Implementation#3548
Connector Healthcheck Implementation#3548ManaswibRane wants to merge 3 commits intointelowlproject:developfrom
Conversation
|
Hello @mlodic ,
Edit : Set openctl but gotta submit my gsoc proposal The two main cases I have tested error and healthy
Incase you need the video test Will move to openctl soon |
|
Implemented the yeti healthcheck too need some cleanup before commits tested with real instance |
ddfb880 to
0593bc1
Compare
0593bc1 to
53f9ef3
Compare
ea511a9 to
f6cd9ab
Compare
|
Only openctl left once I implement that will look into the test faliure(need to add monkeypatches) |
|
Opencti healthcheck implemented Screen.Recording.2026-03-29.214150.mp4 |
f6cd9ab to
261fb54
Compare
mlodic
left a comment
There was a problem hiding this comment.
this is not bad but we need also unittests and adjustment to the logic
| ssl=ssl_param, | ||
| debug=False, | ||
| timeout=10, | ||
| ) |
There was a problem hiding this comment.
how this should be enough to evaluate that the MISP instance is up?
There was a problem hiding this comment.
The next line misp.version Will fidget with that and its good to go then
| token=api_key, | ||
| ssl_verify=ssl_verify, | ||
| ) | ||
| client.health_check() |
There was a problem hiding this comment.
what happens if the health check fails? This is not clear here. I prefer that you explicitly raise the error instead of returning True at the end. Also for the other analyzers. This could bring some bugs and is difficult to maintain
There was a problem hiding this comment.
Needed review if it is good upto this
I tested the error on line 1323 is triggered in api_app/views.py
Will create proper error handlers since all good
261fb54 to
3666af2
Compare
|
A few issues in the current connector implementation to be solved will solve and open a fresh pr later |
|
Hi @mlodic , I am starting with my exams so will have to pause my work but the official docs require token(Authorization header) https://yeti-platform.io/docs/api/ also it failed while I tried and also there is an issue in the post request it should be sent to another endpoint /api/v2/observables/{obs_id}/context misp.py implementation works still the error occurs with no logs, didnt get time to find where the error is |
|
This pull request has been marked as stale because it has had no activity for 10 days. If you are still working on this, please provide some updates or it will be closed in 5 days. |





(Please add to the PR name the issue/s that this PR would close if merged by using a Github keyword. Example:
<feature name>. Closes #999. If your PR is made by a single commit, please add that clause in the commit too. This is all required to automate the closure of related issues.)Connector Healthcheck Implementation. Closes #928
Description
Contains healthcheck function for the Connector MISP
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks (HEAD HTTP requests).get_mocker_response()method of the unittest class. This serves us to provide a valid sample for testing.DataModelfor the new analyzer following the documentation# This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.Ruff) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules