Add ping ip data

[marcwitasee]

No description provided.

[ggmartins]

Have you seen a site responding with an ipv6 address in the dataset? I think, for that you have to use ping6 if I'm not wrong, but that regex should work just fine.

[marcwitasee]

Have you seen a site responding with an ipv6 address in the dataset? I think, for that you have to use ping6 if I'm not wrong, but that regex should work just fine.

No, I haven't seen a site responding with ipv6 so I'm not confident that the regex will match for those, but I can try to do some testing and see if it still works.

[marcwitasee]

Just added another commit with changes to netson.py, adding logic to check the validity of the IP address returned by the regex function in ping_latency. These changes are currently deployed in the global Netrics install on my beta device (980b).

I have not been able to test the regex performance with IPv6 addresses. I don't have an IPv6 compatible connection it seems, so I can't generate test cases on my computer nor does IPv6 seem to be pingable from the IoT lab device. Any suggestions for how to generate some test output? Do we expect IPv6 addresses to show up in the output from the ping command that we run for this test? @ggmartins @tarunmangla @kyle-macmillan

[tarunmangla]

@marcwitasee UChicago network does not support IPv6. You could connect your machine to a cellular hotspot (most cell networks are IPv6 compatible). Here is a sample output using ping6 on a T-Mobile hotspot:

PING6(56=40+8+8 bytes) 2607:fb90:e16e:9a68:f8e0:5d1:63bf:bdbf --> 2607:f8b0:4009:802::200e
16 bytes from 2607:f8b0:4009:802::200e, icmp_seq=0 hlim=57 time=113.656 ms
16 bytes from 2607:f8b0:4009:802::200e, icmp_seq=1 hlim=57 time=137.449 ms
16 bytes from 2607:f8b0:4009:802::200e, icmp_seq=2 hlim=57 time=253.950 ms
16 bytes from 2607:f8b0:4009:802::200e, icmp_seq=3 hlim=57 time=70.219 ms
16 bytes from 2607:f8b0:4009:802::200e, icmp_seq=4 hlim=57 time=245.920 ms

[ggmartins]

Preparing review...