Skip to content

Simplify electron autoupdater #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajimenezriv-internxt wants to merge 22 commits into
base: main
Choose a base branch
from

Simplify electron autoupdater

fb20ea9
Select commit
Loading
Failed to load commit list.
Open

Simplify electron autoupdater #1361

Simplify electron autoupdater
fb20ea9
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 23, 2026 in 1m 7s

Quality Gate failed

Failed conditions
1 Security Hotspot
0.0% Coverage on New Code (required ≥ 80%)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 12 in src/apps/main/electron/autoupdater/verify-hash.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Ensure that tainted data is validated before being used to construct a client-side request URL. 

See more on https://sonarcloud.io/project/issues?id=internxt_drive-desktop&issues=AZ269jXRX5YjU0kPVdz9&open=AZ269jXRX5YjU0kPVdz9&pullRequest=1361

Check failure on line 17 in src/apps/main/electron/autoupdater/show-dialog.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Change this code to not construct the OS command from user-controlled data. 

See more on https://sonarcloud.io/project/issues?id=internxt_drive-desktop&issues=AZ269jTbX5YjU0kPVdz7&open=AZ269jTbX5YjU0kPVdz7&pullRequest=1361
View more details on SonarQubeCloud