[PB-5247] remove old token#1918
Open
TamaraFinogina wants to merge 6 commits intomasterfrom
Open
Conversation
Deploying drive-web with
|
| Latest commit: |
d08bad6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83f3e594.drive-web.pages.dev |
| Branch Preview URL: | https://remove-old-token.drive-web.pages.dev |
7 tasks
larryrider
reviewed
Apr 7, 2026
| } | ||
|
|
||
| return `${baseURL}?mnemonic=${btoa(user.mnemonic)}&token=${btoa(token)}&newToken=${btoa( | ||
| return `${baseURL}?mnemonic=${btoa(user.mnemonic)}&token=${btoa(newToken)}&newToken=${btoa( |
Contributor
There was a problem hiding this comment.
for me we should remove the oldtoken parameter. Sending the newToken instead of the oldToken will break the apps too, so its the same as removing it entirely 🤔
larryrider
previously approved these changes
Apr 8, 2026
CandelR
reviewed
Apr 10, 2026
| return `${baseURL}?mnemonic=${btoa(user.mnemonic)}&token=${btoa(token)}&newToken=${btoa( | ||
| newToken, | ||
| )}&privateKey=${btoa(user.privateKey)}`; | ||
| return `${baseURL}?mnemonic=${btoa(user.mnemonic)}&newToken=${btoa(newToken)}&privateKey=${btoa(user.privateKey)}`; |
Collaborator
There was a problem hiding this comment.
We should remove all token related logic in mobile also before merge this
| const handleSuccessfulAuth = (token: string, user: UserSettings, mnemonic: string): void => { | ||
| const newToken = localStorageService.get(LocalStorageItem.NewToken); | ||
| const handleSuccessfulAuth = (user: UserSettings, mnemonic: string): void => { | ||
| const newToken = localStorageService.get(LocalStorageItem.NewToken) ?? ''; |
Collaborator
There was a problem hiding this comment.
To make it equivalent, I would say that the fallback must be null
Contributor
Author
There was a problem hiding this comment.
cannot use null, newToken must be a string to pass the type check. But I added an explicit check
larryrider
approved these changes
Apr 13, 2026
CandelR
approved these changes
Apr 13, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes deprecated old token
Checklist
Testing Process
unit tests