[PB-5969]: skip zero-byte files in folder uploads to prevent blocking#1932
Open
[PB-5969]: skip zero-byte files in folder uploads to prevent blocking#1932
Conversation
Deploying drive-web with
|
| Latest commit: |
23187a2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3c35102a.drive-web.pages.dev |
| Branch Preview URL: | https://fix-empty-files-folder.drive-web.pages.dev |
terrerox
force-pushed
the
fix/empty-files-folder
branch
from
1606e95 to
103b0fe
Compare
terrerox
force-pushed
the
fix/empty-files-folder
branch
from
103b0fe to
c8742c1
Compare
|
CandelR
reviewed
Apr 16, 2026
Collaborator
CandelR
left a comment
CandelR
left a comment
There was a problem hiding this comment.
Before reviewing the PR, this flow had already been removed. Has someone from Product requested that it be added back? I can see that this task is linked to a bug and there hasn’t been a request to reintroduce this behaviour, which is why I’m asking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Filter out empty files before dispatching the folder upload thunk, and log partial failures instead of aborting the whole folder upload. This prevents zero-byte files (e.g. init.py) from stalling or failing
the entire directory upload.
Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes