[MKT-824]:fix/missing impact tracking for promo codes#1937
Open
jaaaaavier wants to merge 6 commits intomasterfrom
Open
[MKT-824]:fix/missing impact tracking for promo codes#1937jaaaaavier wants to merge 6 commits intomasterfrom
jaaaaavier wants to merge 6 commits intomasterfrom
Conversation
Deploying drive-web with
|
| Latest commit: |
10c9b86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://aa48ca0e.drive-web.pages.dev |
| Branch Preview URL: | https://fix-impact-attribution-coupo.drive-web.pages.dev |
xabg2
reviewed
Apr 24, 2026
| expect(axiosSpy).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should not send to Impact when source is direct and coupon code is not in whitelist', async () => { |
Contributor
There was a problem hiding this comment.
Use When..., then... to describe tests
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue where coupon-only sales were failing to attribute on Impact.
Changes included:
uuidV4foranonymousId: Ensures that conversions without a prior affiliate tracking cookie (impactAnonymousId) provide a valid tracking identifier to our analytics integration, preventing silent payload drops.Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes