[PB-1960]: feat/implement mail address decorator and update email controller#30
Open
[PB-1960]: feat/implement mail address decorator and update email controller#30
Conversation
- Added `mailAddressFactory` as a parameter decorator to extract MailAddress from the request context. - Created unit tests for the mail address decorator to ensure correct functionality. - Updated `EmailController` to use the new `MailAddress` decorator for email parameter extraction, replacing the previous user email extraction method. - Enhanced `MailAccountGuard` to attach the default mail address to the request context and handle cases where no default address is available.
jzunigax2
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve requesting user's mail address to their default email address. Would need a future task to tackle the scenario where one user could have many email addrresses
mailAddressFactoryas a parameter decorator to extract MailAddress from the request context.EmailControllerto use the newMailAddressdecorator for email parameter extraction, replacing the previous user email extraction method.MailAccountGuardto attach the default mail address to the request context and handle cases where no default address is available.