Skip to content

- Update unit tests to assert against EnrichedError wrapping and spec… #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patricioxavier8 merged 1 commit into from
Mar 30, 2026
Merged

- Update unit tests to assert against EnrichedError wrapping and spec… #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Tests/InternxtSwiftCoreTests/Services/Network/DownloadTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,13 @@ final class DownloadTests: XCTestCase {
let destination = getTemporaryDestination()
do {
_ = try await sut.start(bucketId: "bucketNotBucket", fileId: "file123", destination: destination)
XCTFail("Expected an error to be thrown")
} catch let enrichedError as EnrichedError {
XCTAssertEqual(enrichedError.code, .downloadInvalidBucket)
XCTAssertEqual(enrichedError.cause as? DownloadError, DownloadError.InvalidBucketId)
} catch {
XCTAssertEqual(error as? DownloadError, DownloadError.InvalidBucketId)
XCTFail("Expected EnrichedError but got \(type(of: error))")
}

}

// Multipart check until we implement it
Expand Down Expand Up @@ -84,8 +87,11 @@ final class DownloadTests: XCTestCase {

do {
_ = try await sut.start(bucketId: "93535c0bfff5de6d59c8eec72b46b605", fileId: "64d677aeed70fe00082983bc", destination: destination)
XCTFail("Expected an error to be thrown")
} catch let enrichedError as EnrichedError {
XCTAssertEqual(enrichedError.cause as? DownloadError, DownloadError.MultipartDownloadNotSupported)
} catch {
XCTAssertEqual(error as? DownloadError, DownloadError.MultipartDownloadNotSupported)
XCTFail("Expected EnrichedError but got \(type(of: error))")
}
}

Expand Down
31 changes: 18 additions & 13 deletions Tests/InternxtSwiftCoreTests/Services/Network/NetworkFacadeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,11 @@ final class NetworkFacadeTests: XCTestCase {

do {
_ = try await sut.uploadFile(input: inputStream, encryptedOutput: destination, fileSize: 100, bucketId: "93535c0bfff5de6d59c8eec72b46b605", progressHandler: {_ in})
XCTFail("Expected an error to be thrown")
} catch let enrichedError as EnrichedError {
XCTAssertEqual(enrichedError.cause as? NetworkFacadeError, NetworkFacadeError.EncryptedFileNotSameSizeAsOriginal)
} catch {
XCTAssertTrue(error is NetworkFacadeError)
XCTAssertEqual(error as? NetworkFacadeError, NetworkFacadeError.EncryptedFileNotSameSizeAsOriginal)
XCTFail("Expected EnrichedError but got \(type(of: error))")
}
}

Expand All @@ -77,13 +79,13 @@ final class NetworkFacadeTests: XCTestCase {

do {
_ = try await sut.uploadFile(input: inputStream, encryptedOutput: destination, fileSize: 4, bucketId: "93535c0bfff5de6d59c8eec72b46b605", progressHandler: {_ in})
XCTFail("Expected an error to be thrown")
} catch let enrichedError as EnrichedError {
XCTAssertEqual(enrichedError.code, .apiServerError)
let apiError = enrichedError.cause as? APIClientError
XCTAssertEqual(apiError?.statusCode, 500)
} catch {
XCTAssertTrue(error is StartUploadError)
let uploadError: StartUploadError = (error as? StartUploadError)!

XCTAssertEqual(uploadError.apiError?.statusCode, 500)
XCTAssertEqual(String(data: uploadError.apiError!.responseBody, encoding: .utf8), errorMessage)

XCTFail("Expected EnrichedError but got \(type(of: error))")
}
}

Expand Down Expand Up @@ -148,10 +150,11 @@ final class NetworkFacadeTests: XCTestCase {

do {
_ = try await sut.uploadFile(input: inputStream, encryptedOutput: destination, fileSize: 4, bucketId: "93535c0bfff5de6d59c8eec72b46b605", progressHandler: {_ in})
XCTFail("Expected an error to be thrown")
} catch let enrichedError as EnrichedError {
XCTAssertEqual(enrichedError.cause as? UploadError, UploadError.UploadedSizeNotMatching)
} catch {
XCTAssertTrue(error is UploadError)
XCTAssertEqual(error as? UploadError, UploadError.UploadedSizeNotMatching)

XCTFail("Expected EnrichedError but got \(type(of: error))")
}
}

Expand Down Expand Up @@ -244,9 +247,11 @@ final class NetworkFacadeTests: XCTestCase {

do {
_ = try await sut.decryptFile(bucketId: "93535c0bfff5de6d59c8eec72b46b605", destinationURL: destination, progressHandler: {_ in }, encryptedFileDownloadResult: downloadResult)
XCTFail("Expected an error to be thrown")
} catch let enrichedError as EnrichedError {
XCTAssertEqual(enrichedError.cause as? NetworkFacadeError, NetworkFacadeError.FileIsEmpty)
} catch {

XCTAssertEqual(error as? NetworkFacadeError, NetworkFacadeError.FileIsEmpty)
XCTFail("Expected EnrichedError but got \(type(of: error))")
}
}
}
Loading