fix(lib): tisax framework missing version#3898
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
backend/library/libraries/tisax-v5.1.yaml (1)
127-154:⚠️ Potential issue | 🟠 MajorDon't rename existing requirement-node URNs in place without a migration.
These URNs are the persisted identifiers for the imported nodes, not just display text.
backend/library/utils.py:74-82stores the YAMLurn/parent_urnverbatim, andbackend/core/generators.py:317-335rebuilds hierarchy by exactparent_urnlookup. Renaming...:nodeNNto...:<section>:<index>will stop matching for already-imported TISAX v5.1 data unless the updater also rewrites every stored reference. The same risk exists inbackend/library/libraries/tisax-v6.0.2.yaml.Please either keep the legacy URNs stable or ship an explicit migration/alias step with this change.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/library/libraries/tisax-v5.1.yaml` around lines 127 - 154, The change renames persisted URNs in backend/library/libraries/tisax-v5.1.yaml (and similarly in tisax-v6.0.2.yaml), which will break existing imports because backend/library/utils.py (reads/writes urn/parent_urn verbatim around lines 74-82) and backend/core/generators.py (rebuilds hierarchy by exact parent_urn lookup around lines 317-335) rely on stable identifiers; either restore the original URNs exactly as they were (keep legacy urn and parent_urn values) or implement and ship a migration/alias step that updates/aliases all stored references on import (update utils.py to map old→new URNs on read/write and update generators.py to resolve aliases), ensuring backward compatibility for already-imported TISAX data.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@backend/library/libraries/tisax-v5.1.yaml`:
- Around line 127-154: The change renames persisted URNs in
backend/library/libraries/tisax-v5.1.yaml (and similarly in tisax-v6.0.2.yaml),
which will break existing imports because backend/library/utils.py (reads/writes
urn/parent_urn verbatim around lines 74-82) and backend/core/generators.py
(rebuilds hierarchy by exact parent_urn lookup around lines 317-335) rely on
stable identifiers; either restore the original URNs exactly as they were (keep
legacy urn and parent_urn values) or implement and ship a migration/alias step
that updates/aliases all stored references on import (update utils.py to map
old→new URNs on read/write and update generators.py to resolve aliases),
ensuring backward compatibility for already-imported TISAX data.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9e0b9fe2-4f2b-45ed-a78f-f219b153b96f
⛔ Files ignored due to path filters (2)
tools/excel/tisax/tisax-v5.1.xlsxis excluded by!**/*.xlsxtools/excel/tisax/tisax-v6.0.2.xlsxis excluded by!**/*.xlsx
📒 Files selected for processing (2)
backend/library/libraries/tisax-v5.1.yamlbackend/library/libraries/tisax-v6.0.2.yaml
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@backend/library/libraries/tisax-v6.0.2.yaml`:
- Line 28: Update the YAML field publication_date in tisax-v6.0.2.yaml from the
incorrect future date to the official TISAX v6.0.2 release date by replacing the
current value (publication_date: 2026-04-11) with publication_date: 2024-04-03
so the metadata matches the authoritative ENX source.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3bf9f48c-8680-4e53-9205-6bd81fe7e616
📒 Files selected for processing (2)
backend/library/libraries/tisax-v5.1.yamlbackend/library/libraries/tisax-v6.0.2.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- backend/library/libraries/tisax-v5.1.yaml
| \ is to be found in line 17ff." | ||
| version: 2 | ||
| publication_date: 2024-04-15 | ||
| publication_date: 2026-04-11 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the official publication date of TISAX ISA v6.0.2 from ENX (source workbook/release notes)?
💡 Result:
The official publication date of TISAX ISA v6.0.2 (German translation of the Information Security Assessment questionnaire) from ENX/VDA is 2024-04-03, as listed on the official ENX Portal downloads page for German users. This is a copy of the current version used for TISAX assessments ordered after April 1, 2024, officially published by the VDA. The English version is listed as ISA 6.0.3 with date 2024-04-25. No specific release notes or workbook for v6.0.2 were found beyond this listing, but the ENX downloads page serves as the authoritative source indicating availability/publication.
Citations:
- 1: https://enx.com/en-us/TISAX/downloads/
- 2: https://enx.com/TISAX/downloads/
- 3: https://portal.enx.com/de-DE/TISAX/downloads/
- 4: https://linkedin.com/company/isa-guni
Update publication_date to match official TISAX v6.0.2 metadata.
Line 28 contains publication_date: 2026-04-11, but the official publication date of TISAX v6.0.2 from ENX is 2024-04-03. The current date is nearly 2 years ahead of the actual release date and does not match the authoritative source. Update to publication_date: 2024-04-03.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@backend/library/libraries/tisax-v6.0.2.yaml` at line 28, Update the YAML
field publication_date in tisax-v6.0.2.yaml from the incorrect future date to
the official TISAX v6.0.2 release date by replacing the current value
(publication_date: 2026-04-11) with publication_date: 2024-04-03 so the metadata
matches the authoritative ENX source.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
backend/library/libraries/tisax-v6.0.2.yaml (1)
28-28:⚠️ Potential issue | 🟠 MajorCorrect
publication_datefor TISAX v6.0.2 metadata.Line 28 sets
publication_date: 2026-04-11, which is inconsistent with the already flagged official v6.0.2 release metadata (2024-04-03). Please keep the framework publication date, not the PR date.🔧 Suggested fix
-publication_date: 2026-04-11 +publication_date: 2024-04-03🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/library/libraries/tisax-v6.0.2.yaml` at line 28, The publication_date value in the TISAX v6.0.2 metadata is incorrect; update the publication_date field in backend/library/libraries/tisax-v6.0.2.yaml (the publication_date entry) to the official framework release date "2024-04-03" instead of "2026-04-11" so the file reflects the correct v6.0.2 release metadata.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@backend/library/libraries/tisax-v5.1.yaml`:
- Line 25: The publication_date key in this YAML currently uses 2026-04-11 but
must match the canonical TISAX v5.1 publication date used elsewhere; update the
publication_date value to 2024-06-18 so the library metadata aligns with the
repository's canonical date.
---
Duplicate comments:
In `@backend/library/libraries/tisax-v6.0.2.yaml`:
- Line 28: The publication_date value in the TISAX v6.0.2 metadata is incorrect;
update the publication_date field in backend/library/libraries/tisax-v6.0.2.yaml
(the publication_date entry) to the official framework release date "2024-04-03"
instead of "2026-04-11" so the file reflects the correct v6.0.2 release
metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: eccf6664-3fa9-49f1-88e2-5047612d31a0
⛔ Files ignored due to path filters (2)
tools/excel/tisax/tisax-v5.1.xlsxis excluded by!**/*.xlsxtools/excel/tisax/tisax-v6.0.2.xlsxis excluded by!**/*.xlsx
📒 Files selected for processing (2)
backend/library/libraries/tisax-v5.1.yamlbackend/library/libraries/tisax-v6.0.2.yaml
| version: 1 | ||
| publication_date: 2024-06-18 | ||
| version: 2 | ||
| publication_date: 2026-04-11 |
There was a problem hiding this comment.
publication_date should remain the actual TISAX v5.1 publication date.
Line 25 uses 2026-04-11, but this conflicts with existing repository metadata for this URN (backend/core/migrations/0047_loadedlibrary_publication_date_and_more.py, 2024-06-18). Please keep the canonical framework publication date.
🔧 Suggested fix
-publication_date: 2026-04-11
+publication_date: 2024-06-18📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| publication_date: 2026-04-11 | |
| publication_date: 2024-06-18 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@backend/library/libraries/tisax-v5.1.yaml` at line 25, The publication_date
key in this YAML currently uses 2026-04-11 but must match the canonical TISAX
v5.1 publication date used elsewhere; update the publication_date value to
2024-06-18 so the library metadata aligns with the repository's canonical date.
There was a problem hiding this comment.
♻️ Duplicate comments (1)
backend/library/libraries/tisax-v6.0.2.yaml (1)
28-28:⚠️ Potential issue | 🟠 MajorFix incorrect publication date for TISAX v6.0.2 metadata.
Line 28 sets
publication_date: 2026-04-11, which is inconsistent with the established upstream release metadata for ISA v6.0.2 and introduces a future-dated value.Suggested fix
-publication_date: 2026-04-11 +publication_date: 2024-04-03🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@backend/library/libraries/tisax-v6.0.2.yaml` at line 28, The publication_date field in tisax-v6.0.2.yaml is incorrectly set to a future date ("publication_date: 2026-04-11"); update the publication_date value to the correct upstream release date for TISAX v6.0.2 (replace the current 2026-04-11 with the official release date) so the metadata matches the established ISA v6.0.2 release info.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@backend/library/libraries/tisax-v6.0.2.yaml`:
- Line 28: The publication_date field in tisax-v6.0.2.yaml is incorrectly set to
a future date ("publication_date: 2026-04-11"); update the publication_date
value to the correct upstream release date for TISAX v6.0.2 (replace the current
2026-04-11 with the official release date) so the metadata matches the
established ISA v6.0.2 release info.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 75bd0278-1124-4b3d-a65b-567fe05761f1
⛔ Files ignored due to path filters (2)
tools/excel/tisax/tisax-v5.1.xlsxis excluded by!**/*.xlsxtools/excel/tisax/tisax-v6.0.2.xlsxis excluded by!**/*.xlsx
📒 Files selected for processing (2)
backend/library/libraries/tisax-v5.1.yamlbackend/library/libraries/tisax-v6.0.2.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- backend/library/libraries/tisax-v5.1.yaml
3 participants
Just occured that TISAX is now appearing for every version with the same name
This pr fix this for no confusion
Summary by CodeRabbit