Dynamic search mappings - #234
Draft
slint wants to merge 3 commits into
Draft
Conversation
slint
force-pushed
the
dynamic-mappings
branch
from
November 18, 2024 17:00
15e1bbc to
3551abc
Compare
slint
marked this pull request as draft
November 18, 2024 17:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SEARCH_HOSTSfrom envNote
This is a first attempt to support mappings defined via code (instead of raw JSON files). This will probably require an RFC so we can compare different approaches and make sure have an intuitive API while still having some guardrails