Skip to content

chore(analytics): deprecation warnings for v8 API ahead of future major release#8197

Merged
mikehardy merged 5 commits into
mainfrom
analytics-deprecations
Jun 30, 2025
Merged

chore(analytics): deprecation warnings for v8 API ahead of future major release#8197
mikehardy merged 5 commits into
mainfrom
analytics-deprecations

Conversation

@russellwheatley

@russellwheatley russellwheatley commented Dec 20, 2024

Copy link
Copy Markdown
Member

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel

vercel Bot commented Dec 20, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 11:23am

@russellwheatley

russellwheatley commented Dec 20, 2024

Copy link
Copy Markdown
Member Author

@mikehardy - Started this and I wanted to get your thoughts on the modular event methods we've ported over.

The firebase-js-sdk doesn't have methods for every event, they just have logEvent() to be used for custom and reserved events: https://firebase.google.com/docs/reference/js/analytics

Wondering whether we should deprecate all the modular methods we've ported over and just use logEvent()?

examples: https://github.com/invertase/react-native-firebase/blob/main/packages/analytics/lib/modular/index.js#L165-L187

Part of me thinks they're useful but another part thinks we should stick to firebase-js-sdk API 🤔

@russellwheatley russellwheatley changed the title chore(core): deprecation warning for v8 API ahead of future major release chore(analytics): deprecation warning for v8 API ahead of future major release Dec 20, 2024
@mikehardy

Copy link
Copy Markdown
Collaborator

@russellwheatley Deviating from firebase-js-sdk API is a slippery slope and at least personally I can only justify it when there is a native method that's really useful and has no analog we can do with firebase-js-sdk - logEvent seems sufficient as an analog, to me. I don't think the specific methods meet the bar to justify deviation from firebase-js-sdk, so I'd deprecate them and go 100% JS API here

@github-actions

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions Bot added the Stale label Jan 17, 2025
@mikehardy mikehardy force-pushed the v8-deprecations branch 2 times, most recently from 49552e6 to b21ad22 Compare February 3, 2025 13:21
Base automatically changed from v8-deprecations to main February 3, 2025 13:46
@mikehardy mikehardy force-pushed the analytics-deprecations branch from ac79ae1 to b80a247 Compare February 3, 2025 14:08
@mikehardy mikehardy changed the title chore(analytics): deprecation warning for v8 API ahead of future major release chore(analytics): deprecation warnings for v8 API ahead of future major release Feb 3, 2025
@github-actions

github-actions Bot commented Mar 3, 2025

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions github-actions Bot added the Stale label Mar 3, 2025
@github-actions github-actions Bot closed this Mar 18, 2025
@mikehardy mikehardy reopened this Mar 19, 2025
@github-actions github-actions Bot removed the Stale label Mar 19, 2025
@github-actions

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@github-actions

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 2 months with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 15 days until this gets closed automatically

@russellwheatley russellwheatley marked this pull request as ready for review May 30, 2025 08:40
@russellwheatley russellwheatley requested a review from mikehardy June 2, 2025 12:02
@MichaelVerdon MichaelVerdon marked this pull request as draft June 10, 2025 10:12
@MichaelVerdon MichaelVerdon marked this pull request as ready for review June 10, 2025 10:12

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - looks good in local testing

@mikehardy mikehardy merged commit aa1bdd3 into main Jun 30, 2025
17 of 18 checks passed
@mikehardy mikehardy deleted the analytics-deprecations branch June 30, 2025 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants