feat(firebase-ai): create ai package, vertexai wraps around it#8555
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ai package, vertexai to wrap around itai package, vertexai wraps around it
Ehesp
reviewed
Jun 23, 2025
Lyokone
reviewed
Jul 1, 2025
dackers86
reviewed
Jul 11, 2025
Collaborator
|
Looking into this one now for review - noticed Other tests were failing because TextEncoder implementation seems to be missing and is needed ? Unexpected as it seems that should have been failing for a while if so, but...okay rebased to main and put an in situ implementation of the string -> uint8array conversion in the storage library and it passes locally, hopefully this goes green in CI - will finish the review later |
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Cynthia J <cynthiajoan@users.noreply.github.com>
cynthiajoan
approved these changes
Aug 12, 2025
This was referenced Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
aipackage. Kept relevant types invertexaipackage and deprecated them.firebase-js-sdk.vertexaiandgoogleai.dist/so opted to makeaipackage a dependency which I think is a better way of doing it.aiexample app for illustration and tested latestvertexaiandaiimplementations which surfaced a couple of subtle bugs that have been resolved.Important
vertexaifor this pull request.Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter