Skip to content

ci(apple): switch to iOS simulator 16#8558

Merged
mikehardy merged 2 commits into
mainfrom
fix-ci-ios
Jun 7, 2025
Merged

ci(apple): switch to iOS simulator 16#8558
mikehardy merged 2 commits into
mainfrom
fix-ci-ios

Conversation

@russellwheatley

@russellwheatley russellwheatley commented Jun 6, 2025

Copy link
Copy Markdown
Member

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel

vercel Bot commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 8:48pm

@russellwheatley russellwheatley changed the title ci(apple): attempt at different simulator ci(apple): switch to iOS simulator 16 Jun 6, 2025
mikehardy
mikehardy approved these changes Jun 6, 2025
View reviewed changes

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help local testing as well as the current Xcode SDKs easily let you make a new iPhone 15 emulator but no longer come with one pre-defined, and it's a dev ex friction point that you have to create one

Let me check to see if this impacts developer docs or anything before merging but otherwise I'm +1

@mikehardy
docs(test): tidy up developer documentation
3209609 
- node version requirement is much higher now
- yarn v3+ and corepack means it should not be installed globally
- Xcode version is much higher now
@mikehardy

mikehardy commented Jun 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

dev docs were a little crufty but not related to this - you needed to create an iPhone 15 simulator instance in order to run the tests but that's relatively recent as a requirement and it was never documented 🫣

I pushed a commit with a tiny cleanup to the docs for the unrelated items though - node version, xcode version, yarn not global install now...

This looks good to go to me and is a blocker for any other PR so I'm going to merge and beg forgiveness if anything breaks. Obviously happy to help mop up if so

@mikehardy mikehardy marked this pull request as ready for review June 6, 2025 20:47
@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Jun 6, 2025
@mikehardy mikehardy merged commit 2af28df into main Jun 7, 2025
17 checks passed
@mikehardy mikehardy deleted the fix-ci-ios branch June 7, 2025 01:07
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikehardy mikehardy mikehardy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @mikehardy