chore(perf): deprecations for v8 API ahead of future major release#8585
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
russellwheatley
requested changes
Jun 24, 2025
russellwheatley
left a comment
Member
There was a problem hiding this comment.
We should make these three settable from initialisePerformance():
https://github.com/invertase/react-native-firebase/blob/main/packages/perf/lib/index.js#L55-L103
dataCollectionEnabled and isPerformanceCollectionEnabled are the same. The moduler method of initialisePerformance() needs to be updated. See JS docs for the options:
MichaelVerdon
commented
Jun 24, 2025
russellwheatley
requested changes
Jun 24, 2025
russellwheatley
approved these changes
Jun 24, 2025
df98cef to
b67d0df
Compare
mikehardy
approved these changes
Jul 1, 2025
mikehardy
left a comment
Collaborator
There was a problem hiding this comment.
Nice! LGTM - squashed it down to a single commit, rebased it to main to make sure it's up to date for CI and pending merge if CI goes green
b67d0df to
7f237d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter