Skip to content

chore(perf): deprecations for v8 API ahead of future major release#8585

Merged
mikehardy merged 1 commit into
mainfrom
performance-deprecations
Jul 1, 2025
Merged

chore(perf): deprecations for v8 API ahead of future major release#8585
mikehardy merged 1 commit into
mainfrom
performance-deprecations

Conversation

@MichaelVerdon

Copy link
Copy Markdown
Contributor

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel

vercel Bot commented Jun 23, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2025 7:37pm

@russellwheatley russellwheatley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make these three settable from initialisePerformance():
https://github.com/invertase/react-native-firebase/blob/main/packages/perf/lib/index.js#L55-L103

dataCollectionEnabled and isPerformanceCollectionEnabled are the same. The moduler method of initialisePerformance() needs to be updated. See JS docs for the options:

https://firebase.google.com/docs/reference/js/performance.md?_gl=1*wajhyu*_up*MQ..*_ga*NTg3Mjc2MzMuMTc1MDc1MzIxMQ..*_ga_CW55HF8NVT*czE3NTA3NTMyMTAkbzEkZzAkdDE3NTA3NTMyMTAkajYwJGwwJGgw#initializeperformance_980350e

Comment thread packages/perf/lib/modular/index.js
Comment thread packages/perf/lib/modular/index.js Outdated
Comment thread packages/perf/lib/modular/index.js

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM - squashed it down to a single commit, rebased it to main to make sure it's up to date for CI and pending merge if CI goes green

@mikehardy mikehardy force-pushed the performance-deprecations branch from b67d0df to 7f237d0 Compare July 1, 2025 19:22
@mikehardy mikehardy merged commit 42f7194 into main Jul 1, 2025
15 of 16 checks passed
@mikehardy mikehardy deleted the performance-deprecations branch July 1, 2025 19:22
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants