chore(app-distribution): deprecations for v8 API ahead of future major release#8587
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MichaelVerdon
requested review from
mikehardy and
russellwheatley
and removed request for
mikehardy
russellwheatley
requested changes
Jun 25, 2025
| @@ -1,4 +1,5 @@ | |||
| import { getApp } from '@react-native-firebase/app'; | |||
| import { MODULAR_DEPRECATION_ARG } from '../../../app/lib/common'; | |||
Member
There was a problem hiding this comment.
I've just noticed this, and it ought to be changed in the other PRs for deprecations. Import like this:
import { MODULAR_DEPRECATION_ARG } from '@react-native-firebase/app/lib/common';
Contributor
Author
There was a problem hiding this comment.
All done on all PRs
mikehardy
force-pushed
the
app-distribution-deprecations
branch
from
d330c01 to
849864f
Compare
mikehardy
approved these changes
Jul 1, 2025
mikehardy
left a comment
mikehardy
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - another wonderful small one - rebased on main and squashed to single commit, pending clean CI run
mikehardy
force-pushed
the
app-distribution-deprecations
branch
from
849864f to
b0ab667
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Release Summary
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter