Skip to content

feat!: bump firebase-ios-sdk to 12.0.0#8629

Merged
mikehardy merged 1 commit into
mainfrom
ios-sdk-12.0.0
Aug 4, 2025
Merged

feat!: bump firebase-ios-sdk to 12.0.0#8629
mikehardy merged 1 commit into
mainfrom
ios-sdk-12.0.0

Conversation

@russellwheatley

@russellwheatley russellwheatley commented Jul 29, 2025

Copy link
Copy Markdown
Member

Description

trackingId has been removed from firebase-ios-sdk: https://firebase.google.com/support/release-notes/ios#version_1200_-_july_15_2025

I've kept the gaTrackingId API in the JS code because it appears android still uses it: https://firebase.google.com/docs/reference/android/com/google/firebase/FirebaseOptions?_gl=1*dtmd6b*_up*MQ..*_ga*MzIzOTI0NDg4LjE3NTM5NjIwMjM.*_ga_CW55HF8NVT*czE3NTM5NjQxOTMkbzIkZzAkdDE3NTM5NjQxOTMkajYwJGwwJGgw#gaTrackingId()

Although we could possibly update it to match firebase-js-sdk which would be measurementId?

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel

vercel Bot commented Jul 29, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 3:17pm

@russellwheatley russellwheatley changed the title feat: bump Firebase iOS SDK to 12.0.0 feat!: bump Firebase iOS SDK to 12.0.0 Jul 31, 2025
@russellwheatley russellwheatley marked this pull request as ready for review July 31, 2025 17:14

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as we're breaking I think truing up the API to measurement vs tracking ID makes sense - we don't get frequent chances to clear out cruft, let's clear it out

That may imply that people need to download new a new set of plist/json firebase config files if theirs are really old I think...unsure

Comment thread packages/app/package.json
Comment thread packages/app/package.json
@russellwheatley

Copy link
Copy Markdown
Member Author

I think all that is left to do is to add:

BREAKING CHANGE: iOS mininum target now 15.0, was 13.0

to commit body when merging.

@russellwheatley

Copy link
Copy Markdown
Member Author

as long as we're breaking I think truing up the API to measurement vs tracking ID makes sense - we don't get frequent chances to clear out cruft, let's clear it out

That may imply that people need to download new a new set of plist/json firebase config files if theirs are really old I think...unsure

I don't think that will be necessary, ios release notes suggest it wasn't used/obsolete so I think having that property in plist will just be unused. I had a look at service info plist from 8 years ago and don't see analytics ID: https://github.com/invertase/react-native-firebase/blob/9308994db23b3d1acf903f94f12e0b2eabe84807/tests/ios/GoogleService-Info.plist so don't think it's ever been part of the downloaded service file.

BREAKING CHANGE: new minimums: iOS 15+, Xcode 16.2+

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I've got this one all rebased correctly to fix up conflicts

Looks good to go, excellent

@mikehardy mikehardy changed the title feat!: bump Firebase iOS SDK to 12.0.0 feat!: bump firebase-ios-sdk to 12.0.0 Aug 4, 2025
@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed Needs Attention labels Aug 4, 2025
@mikehardy mikehardy merged commit e3d6d22 into main Aug 4, 2025
18 of 19 checks passed
@mikehardy mikehardy deleted the ios-sdk-12.0.0 branch August 4, 2025 16:59
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants