-
Notifications
You must be signed in to change notification settings - Fork 2.3k
chore(repo): add Gemini Code Assist config #8998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
07ccf9e
chore(repo): add Gemini Code Assist config
dackers86 59c2c82
chore(repo): add Gemini review style guide
dackers86 f901210
chore(app): add modular API change for Gemini review
dackers86 bf84551
Revert "chore(app): add modular API change for Gemini review"
dackers86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| have_fun: false | ||
| memory_config: | ||
| disabled: false | ||
| code_review: | ||
| disable: false | ||
| comment_severity_threshold: LOW | ||
| max_review_comments: -1 | ||
| pull_request_opened: | ||
| help: true | ||
| summary: true | ||
| code_review: true | ||
| include_drafts: true | ||
| ignore_patterns: | ||
| - "**/node_modules/**" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # React Native Firebase Gemini Review Guide | ||
|
|
||
| If an `AGENTS.md` file exists at the repository root, follow that guidance first. | ||
|
|
||
| If no root `AGENTS.md` file exists, use the guidance below. | ||
|
|
||
| ## Testing expectations | ||
|
|
||
| - Suggest tests when behavior changes or regression risk increases. | ||
| - Prefer focused tests near the changed package rather than broad new coverage. | ||
| - Avoid asking for redundant tests when existing coverage already appears sufficient. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,6 +115,14 @@ export function getApp(name?: string): ReactNativeFirebase.FirebaseApp { | |
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Retrieves the default Firebase app instance. | ||
| * @returns The default Firebase app instance. | ||
| */ | ||
| export function getDefaultApp(): ReactNativeFirebase.FirebaseApp { | ||
| return getApp(); | ||
| } | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| /** | ||
| * Sets the log level across all Firebase SDKs. | ||
| * @param logLevel - The log level to set ('debug', 'verbose', 'info', 'warn', 'error', 'silent'). | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated unused function committed with config-only PR
Low Severity
The
getDefaultAppfunction is a new public API export that is never used anywhere in the codebase and is unrelated to the PR's stated purpose of adding Gemini Code Assist configuration. It's a trivial wrapper aroundgetApp()with no arguments, which already returns the default app by design. This function doesn't exist in the standard Firebase JS SDK API and appears to have been accidentally included — possibly as a test artifact for verifying the Gemini integration.Reviewed by Cursor Bugbot for commit f901210. Configure here.