Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .gemini/config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
have_fun: false
memory_config:
disabled: false
code_review:
disable: false
comment_severity_threshold: LOW
max_review_comments: -1
pull_request_opened:
help: true
summary: true
code_review: true
include_drafts: true
ignore_patterns:
- "**/node_modules/**"
12 changes: 12 additions & 0 deletions .gemini/styleguide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# React Native Firebase Gemini Review Guide

If an `AGENTS.md` file exists at the repository root, follow that guidance first.

If no root `AGENTS.md` file exists, use the guidance below.

## Testing expectations

- Suggest tests when behavior changes or regression risk increases.
- Prefer focused tests near the changed package rather than broad new coverage.
- Avoid asking for redundant tests when existing coverage already appears sufficient.

8 changes: 8 additions & 0 deletions packages/app/lib/modular.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@ export function getApp(name?: string): ReactNativeFirebase.FirebaseApp {
);
}

/**
* Retrieves the default Firebase app instance.
* @returns The default Firebase app instance.
*/
export function getDefaultApp(): ReactNativeFirebase.FirebaseApp {
return getApp();
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated unused function committed with config-only PR

Low Severity

The getDefaultApp function is a new public API export that is never used anywhere in the codebase and is unrelated to the PR's stated purpose of adding Gemini Code Assist configuration. It's a trivial wrapper around getApp() with no arguments, which already returns the default app by design. This function doesn't exist in the standard Firebase JS SDK API and appears to have been accidentally included — possibly as a test artifact for verifying the Gemini integration.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f901210. Configure here.


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The getDefaultApp function is redundant because getApp() already returns the default Firebase app instance when called without arguments. To maintain parity with the standard Firebase JS SDK Modular API and keep the public API surface area minimal, it is recommended to remove this function.

/**
* Sets the log level across all Firebase SDKs.
* @param logLevel - The log level to set ('debug', 'verbose', 'info', 'warn', 'error', 'silent').
Expand Down
Loading