Skip to content

refactor(ml): migrate to TypeScript#9005

Merged
mikehardy merged 8 commits into
mainfrom
ml-typescript
Jun 7, 2026
Merged

refactor(ml): migrate to TypeScript#9005
mikehardy merged 8 commits into
mainfrom
ml-typescript

Conversation

@russellwheatley

Copy link
Copy Markdown
Member

Description

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the ML package within the repository to use TypeScript for its source code. This change enhances type safety, improves maintainability, and aligns the package with modern development standards by utilizing react-native-builder-bob for the build process. The existing public API remains supported through deprecation markers to ensure backward compatibility for consumers.

Highlights

  • TypeScript Migration: Converted the ML package source files from JavaScript to TypeScript to improve type safety and developer experience.
  • Build Configuration: Updated package.json to utilize react-native-builder-bob for compilation and added a dedicated tsconfig.json for the ML package.
  • API Deprecation: Marked the FirebaseMLTypes namespace as deprecated in favor of direct type exports, while maintaining backward compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@russellwheatley russellwheatley changed the title refactor(ml): convert package sources to TypeScript refactor(ml): migrate to TypeScript May 1, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the ML package to support modular APIs, updates namespaced types with deprecation notices, and integrates react-native-builder-bob for the build process. The getML function should be simplified to avoid redundant app lookups when an instance is already provided.

Comment thread packages/ml/lib/modular.ts
@github-actions

Copy link
Copy Markdown

Hello 👋, this PR has been opened for more than 14 days with no activity on it.

If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing!

You have 7 days until this gets closed automatically

@github-actions github-actions Bot added the Stale label May 15, 2026
@github-actions github-actions Bot closed this Jun 5, 2026
@mikehardy mikehardy reopened this Jun 6, 2026
@mikehardy mikehardy marked this pull request as ready for review June 6, 2026 00:07
@github-actions github-actions Bot removed the Stale label Jun 6, 2026

@mikehardy mikehardy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all fixed up locally after rebase onto main, passes local verification and CI should go green

@mikehardy mikehardy merged commit 2ed934c into main Jun 7, 2026
20 checks passed
@mikehardy mikehardy deleted the ml-typescript branch June 7, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants