Add passkey authentication flow to UI.#3001
Open
svenbledt wants to merge 5 commits intoinvoiceninja:developfrom
Open
Add passkey authentication flow to UI.#3001svenbledt wants to merge 5 commits intoinvoiceninja:developfrom
svenbledt wants to merge 5 commits intoinvoiceninja:developfrom
Conversation
Integrate WebAuthn helpers and passkey management/login UI so CI can validate passkey sign-in and settings behavior.
|
|
Signed-off-by: David Bomba <turbo124@gmail.com>
Member
|
@beganovich i've pushed some fixes to make this work. could you please re-review. |
beganovich
requested changes
Mar 11, 2026
Member
beganovich
left a comment
beganovich
left a comment
There was a problem hiding this comment.
Looking sharp! Please see comments.
| return bytes.buffer; | ||
| } | ||
|
|
||
| export function prepareCreationOptions(publicKey: any) { |
Member
There was a problem hiding this comment.
Is it possible to provide types for these?
(also on lines 49, 65, 77, 103, 58, 70)
Comment on lines
+267
to
+274
| <Button | ||
| behavior="button" | ||
| disabled={isFormBusy} | ||
| variant="block" | ||
| onClick={handlePasskeyLogin} | ||
| > | ||
| {t('login_with_passkey')} | ||
| </Button> |
Member
There was a problem hiding this comment.
I think we should hide this button if there's no support for this API.
const useWebAuthnSupport = () => {
const [isSupported, setIsSupported] = useState(false);
useEffect(() => {
setIsSupported(typeof window !== 'undefined' &&
typeof window.PublicKeyCredential !== 'undefined');
}, []);
return isSupported;
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate WebAuthn helpers and passkey management/login UI so CI can validate passkey sign-in and settings behavior.