ApiProvider: Replace old psp with new PaymentServiceProvider - #284
Merged
Conversation
… logpay_payment_method_types, Use PaymentMethodType instead of ApiPaymentMethodType, clean up
elmira-y
changed the title
StefMa
requested changes
Jul 30, 2026
StefMa
left a comment
StefMa
left a comment
Collaborator
There was a problem hiding this comment.
Nice job! 🧑🚀
I think we shouldn't crash in case the receive an unkown PSP.
Otherwise more nitpicking comments, as always 💁
Collaborator
|
One more thing, so I don't have to add it in a separate PR 🤓 : |
…own payment service provider types gracefully
…ename test functions
StefMa
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Description
ApiProvider: Add PaymentServiceProvider, UsePaymentMethodTypeinstead ofApiPaymentMethodType, Removepspstripe_account_idstripe_payment_method_typeslogpay_payment_method_typesApiPaymentMethodType: RemovePSP_PROVIDEDTest artifact
Test models updated?
In case you created a new APIObject or extracted one,
make sure to update the test fakes in
test/src/commonMain/modelsas well.Changes to existing models will probably fail on testing and are noticed by the CI.
Test services updated?
In case you created a new service or extracted one,
make sure to update the test fakes in
test/src/commonMain/servicesas well.Changes to existing services will probably fail on testing and are noticed by the CI.