Drop build date from generated file - #704
Merged
Merged
Conversation
zturtleman
requested changes
Jul 23, 2025
zturtleman
left a comment
zturtleman
left a comment
There was a problem hiding this comment.
It seems fine to remove the time stamp in the generated file at build/*/tools/rcc/dagcheck.c. The file metadata has the time and it's not expected to be distributed.
There is one minor issue that could be fixed.
for reproducible builds. Without this, dagcheck.c in the debugsource package varies across builds.
zturtleman
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop build date from generated file for reproducible builds.
Without this, dagcheck.c in the debugsource package varies across builds.
Alternatively, we could solve it like in #414