Use WinINet for HTTP downloads on Windows - #738
Merged
Conversation
zturtleman
reviewed
Jul 18, 2025
zturtleman
reviewed
Jul 18, 2025
zturtleman
reviewed
Jul 18, 2025
zturtleman
reviewed
Jul 18, 2025
zturtleman
reviewed
Jul 18, 2025
timangus
force-pushed
the
split-http-method
branch
2 times, most recently
from
July 19, 2025 10:21
d90668a to
df1cb0d
Compare
|
Looks good to me. Thanks for working on this. |
Member
Author
|
I'll leave this up for a couple more days unless anyone else has points of view, then merge. |
zturtleman
reviewed
Jul 21, 2025
timangus
force-pushed
the
split-http-method
branch
from
July 22, 2025 13:51
df1cb0d to
991ca39
Compare
timangus
force-pushed
the
split-http-method
branch
from
July 22, 2025 13:54
991ca39 to
f8bcd25
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After licensing issues kiboshed an alternative means (#733) of solving the ongoing Windows build failure, I've implemented @zturtleman 's suggestion of using the Windows API for HTTP downloads on that platform. The actual download API part of it is refreshingly simple, particularly given the often slightly obscure APIs Windows is renowned for. Anyway, most of the change here is abstracting away the means of download from the rest of the client code. I've also updated Curl and fixed some warnings; not really related to the major change here, but not worth opening another PR over.