Use deploy-to-vercel-action instead of vercel cli#1026
Use deploy-to-vercel-action instead of vercel cli#1026Dr-Electron wants to merge 3 commits intomainfrom
Conversation
jlvandenhout
left a comment
jlvandenhout
left a comment
There was a problem hiding this comment.
I have no clue anymore why I did it the way I did, but if this now works, hey, it works!
I think this was done by Begoña. So you are fine |
Co-authored-by: Jeroen van den Hout <jlvandenhout@gmail.com>
VmMad
left a comment
VmMad
left a comment
There was a problem hiding this comment.
hey @Dr-Electron! I was reviewing the workflow and I don't know if using this action right now is the best idea. I left some comments:
| VERCEL_ORG_ID: ${{ secrets.VERCEL_ORG_ID }} | ||
| VERCEL_PROJECT_ID: ${{ secrets.VERCEL_PROJECT_ID }} | ||
| PR_LABELS: false | ||
| PREBUILT: true |
There was a problem hiding this comment.
This is not going to work because neither FORCE or PREBUILT are in the latest released version of this action.
And judging by the workflow it looks like it might be an important flag. Just letting you know.
There was a problem hiding this comment.
Good catch. Thanks for that. We can just wait for the next release or add the latest changes from the repo.
@jlvandenhout wdyt?
There was a problem hiding this comment.
Yeah, after the restructure we will have a much less complex build, so we might go back to a more vanilla Vercel workflow anyway.
There was a problem hiding this comment.
Ok. Will convert this to a DRAFT in the meantime. @VmMad thanks for your help ❤️
3 participants
Description of change
I switched to this action to make the setup more straight forward
Links to any relevant issues
Fixes #1017
Type of change
Change checklist