Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
96d7e8f to
d9767c6
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
a3e6154 to
96643a0
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
96643a0 to
7a723b9
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
7a723b9 to
571942e
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
571942e to
fc1e22c
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
c8d757e to
dfdda09
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
…aining compat types
ed92479 to
c868b4f
Compare
|
✅ Vercel Preview Deployment is ready! |
c868b4f to
97f2f1b
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
|
✅ Vercel Preview Deployment is ready! |
There was a problem hiding this comment.
please, remove the whole file
| // zklogin::check_zklogin_id | ||
| check_zklogin_id_cost_base: Option<u64>, | ||
| // zklogin::check_zklogin_issuer | ||
| check_zklogin_issuer_cost_base: Option<u64>, | ||
|
|
| // zklogin::check_zklogin_id | ||
| check_zklogin_id_cost_base: Option<u64>, | ||
| // zklogin::check_zklogin_issuer | ||
| check_zklogin_issuer_cost_base: Option<u64>, | ||
|
|
There was a problem hiding this comment.
should be marked as deprecated
There was a problem hiding this comment.
to be removed from the feature flag list:
- zklogin_auth
- enable_jwk_consensus_updates
- accept_zklogin_in_multisig
in the new protocol version (v25) these should be set to None
- zklogin_max_epoch_upper_bound_delta
- max_jwk_votes_per_validator_per_epoch
- max_age_of_jwk_in_epochs
- check_zklogin_id_cost_base
- check_zklogin_issuer_cost_base
Then, remove all the related set functions
There was a problem hiding this comment.
@iotaledger/vm-language TODO: check if these native functions and maybe the whole file can be removed.
There was a problem hiding this comment.
We can remove it in the next release, the compatibility test test_protocol_upgrade_compatibility_imp failed due to old version still have the zk function, and the VM will look up the native function table at module linking. So we still need the stubs now, otherwise it produced this error:
VMError { major_status: MISSING_DEPENDENCY, ...,
location: Module(ModuleId { address: 0x2, name: "zklogin_verified_id" }),
indices: [(FunctionHandle, 0)] }
There was a problem hiding this comment.
In the GenericSignature enum, the ZKLogin variant should be kept, but maybe the inner type can be removed (making it possible to delete the zk_login_authenticator.rs file).
|
✅ Vercel Preview Deployment is ready! |
Description of change
[run-ci]
Links to any relevant issues
None
How the change has been tested
Release Notes
jwk_fetch_interval_secondsandzklogin_oauth_providersconfig optionsZkLoginAuthenticatorandZkLoginPublicIdentifierschemasverifyZkloginSignaturequeryZkLoginIntentScopeenum andZkLoginVerifyResulttypezk-login-sign-and-execute-tx,zk-login-enter-token,zk-login-sig-verify,zk-login-insecure-sign-personal-messagedecode-or-verify-txnow shows "zkLogin is not supported" for zkLogin transactions