feat(wallet-dashboard): collect vesting ptb#10912
feat(wallet-dashboard): collect vesting ptb#10912brancoder merged 46 commits intofeature/sunset-vestingfrom
Conversation
…ast payout is unlocked
…ollect-vesting-ptb
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
github-actions
bot
added
the
wallet-dashboard
evavirseda
changed the title
brancoder
left a comment
brancoder
left a comment
There was a problem hiding this comment.
we should investigate the Collect transaction when there is a mismatch in networks between dashboard and wallet ex. dahsboard is on testnet and wallet is on devnet
this error is thrown in transaction approval window:
we investigated this 🕵️ the reason: it tried to look up testnet objects on devnet and those objects don’t exist there |
# Description of change <details> <summary>Screenshots 👀 </summary> <img width="433" height="750" alt="Screenshot from 2026-03-20 10-02-09" src="https://github.com/user-attachments/assets/4c557738-48dd-43dd-a32e-d6a5d007fea7" /> <img width="1081" height="548" alt="Screenshot from 2026-03-20 11-00-29" src="https://github.com/user-attachments/assets/ea1a55ed-bada-47fd-ac6f-8a80703ccaaf" /> <img width="956" height="475" alt="Screenshot from 2026-03-20 11-00-48" src="https://github.com/user-attachments/assets/0ec10edb-7b54-43ec-b2e3-989f7c7587ef" /> <img width="1194" height="708" alt="Screenshot from 2026-03-20 11-01-20" src="https://github.com/user-attachments/assets/fbd93210-5d16-40d4-805f-4f44de660784" /> </details> ## Links to any relevant issues fixes #10799 ## How the change has been tested Describe the tests that you ran to verify your changes. Make sure to provide instructions for the maintainer as well as any relevant configurations. --------- Co-authored-by: Mario Sarcevic <mario.sarcevic@iota.org>
# Description of change <img width="1293" height="894" alt="image" src="https://github.com/user-attachments/assets/e35679bc-3af6-49b6-813e-ef99d295d04c" /> ## Links to any relevant issues :warning: nested PR from #10912 fixes #10890 ## How the change has been tested To test this PR, you need to manually set up a validator on a local network and turn it into inactive --------- Co-authored-by: Bran <52735957+brancoder@users.noreply.github.com>
brancoder
left a comment
brancoder
left a comment
There was a problem hiding this comment.
we could add link to explorer to Collect Summary and also check why summary doesn't display the unlocked objects and other details.
ex. tx : https://explorer.iota.org/txblock/4Mo7HvZCjkTo63Yit1M7Gm2XHAxVYzL7A82mFUzXdXmc?network=testnet
Colect summary 👇
brancoder
left a comment
brancoder
left a comment
There was a problem hiding this comment.
we decided to show the standard Transaction Dialog instead Collect Summary Dialog
There was a problem hiding this comment.
we can disable the Collect button while isSendingTransaction
const { mutateAsync: signAndExecuteTransaction, isPending: isSendingTransaction } =
useSignAndExecuteTransaction();
5 participants
Description of change
example of collect transaction
(pool_id, stake_activation_epoch)and merge withstaking_pool::join_staked_iotatimelocked_staking::join_staked_iota, which also checksexpiration_timestamp_msand would abort for stakes from different vesting periodsLinks to any relevant issues
fixes #10800
How the change has been tested
SUPPLY_INCREASE_STARTING_VESTING_YEARfrom2023to2024because the testing objects that you created expire in2026, but the logic only considers staker up to2025Testing Collect Transaction with Existing Stake Objects
To reproduce this scenario:
❗ Make sure that the validator is the same for timelocked staking (vesting fast example) and regular stake
This test ensures that the collect transaction correctly unlocks timelocked stake and adds it to the existing staking object in the pool