upstream(core): Rename Accumulator to GlobalStateHash#11186
Open
jkrvivian wants to merge 1 commit intocore-protocol/upstream-changes/mainnet-1.48.4-1.49.2from
Open
upstream(core): Rename Accumulator to GlobalStateHash#11186jkrvivian wants to merge 1 commit intocore-protocol/upstream-changes/mainnet-1.48.4-1.49.2from
jkrvivian wants to merge 1 commit intocore-protocol/upstream-changes/mainnet-1.48.4-1.49.2from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
bingyanglin
reviewed
Apr 9, 2026
| pub(crate) struct CheckpointExecutionState { | ||
| pub data: CheckpointExecutionData, | ||
| accumulator: Option<Accumulator>, | ||
| state_hasher: Option<GlobalStateHash>, |
Contributor
There was a problem hiding this comment.
I am a bit confused it is hash or hasher? Because there is a struct called GlobalStateHasher.
alexsporn
reviewed
Apr 9, 2026
| &self, | ||
| checkpoint: &CheckpointSequenceNumber, | ||
| accumulator: &Accumulator, | ||
| accumulator: &GlobalStateHash, |
Member
There was a problem hiding this comment.
here the param is still called accumulator
semenov-vladyslav
approved these changes
Apr 9, 2026
Contributor
semenov-vladyslav
left a comment
semenov-vladyslav
left a comment
There was a problem hiding this comment.
Accumulator is a proper cryptographic construction with certain properties, so Accumulator as identifier is more appropriate. Accumulator value is then hashed to get a state hash, so Hasher is also valid term but it hides the properties of cryptographic accumulator.
Contributor
|
Does #11165 fix the test failure? |
piotrm50
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Rename the Accumulator to GlobalStateHash to make room for the new Accumulator. File renames:
accumulator.rs→global_state_hash.rs,state_accumulator.rs→global_state_hasher.rs. Key type renames:Accumulator→GlobalStateHash,StateAccumulator→GlobalStateHasher,AccumulatorStore→GlobalStateHashStore.Links to any relevant issues
Part of #11101
How the change has been tested