skip tests that require local node#817
Merged
dessaya merged 1 commit intoiotaledger:ql-devfrom Apr 2, 2026
Merged
Conversation
Comment on lines
+24
to
+26
| if !l1starter.IsLocalConfigured() { | ||
| t.Skip("test requires local node configuration") | ||
| } |
Collaborator
There was a problem hiding this comment.
I think this should be something like if l1starter.IsSimulator() {. Because we would still want to run this tests against real network
chriscandless
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.