[irods/irods#7265] Minor reorganization + CMake TLC#155
Merged
alanking merged 1 commit intoirods:mainfrom Mar 14, 2024
Merged
Conversation
SwooshyCueb
changed the title
SwooshyCueb
force-pushed
the
cmake-tlc.main
branch
2 times, most recently
from
e174396 to
81b5e16
Compare
Contributor
|
Ignore that PR. I have to do more investigation before that can be merged. If this work is ready for review, let's go ahead and take it out of draft. |
Member
Author
|
Done |
Member
Author
|
Once this PR is merged, please create a 4-3-stable branch |
alanking
approved these changes
Mar 13, 2024
Contributor
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Feel free to ignore the suggested name change. I think everything looks fine as-is.
korydraughn
approved these changes
Mar 13, 2024
Contributor
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Looks good.
Pound it.
- Project tree structure reorganized to resemble that of main irods repo. - Added quotes around paths in CMake files. - Removed CMAKE_SHARED_LINKER_FLAGS_INIT and CMAKE_SHARED_LINKER_FLAGS_RELEASE_INIT, as no shared libraries are built. - Removed unused postinst script for nonexistent data_world package - Removed rpm package dependency declaration on openssl - Fixed postinst CPack variables
SwooshyCueb
force-pushed
the
cmake-tlc.main
branch
from
81b5e16 to
752f650
Compare
Member
Author
|
#'d |
Contributor
|
4-3-stable branch created based on 8ac1fa1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In service of irods/irods#7265
This does not break compatibility with 4.3.1.
I didn't notice that there was still an open PR (#141) until just now, so I'd prefer to wait until that is merged and then rebase.