Added Reservation API, poollet and broker implementation - #1172
Closed
lukasfrank wants to merge 29 commits into
Closed
Added Reservation API, poollet and broker implementation#1172lukasfrank wants to merge 29 commits into
Reservation API, poollet and broker implementation#1172lukasfrank wants to merge 29 commits into
Conversation
# Conflicts: # client-go/applyconfigurations/utils.go # client-go/informers/externalversions/compute/v1alpha1/reservation.go # client-go/ironcore/versioned/typed/compute/v1alpha1/fake/fake_reservation.go # client-go/ironcore/versioned/typed/compute/v1alpha1/reservation.go
# Conflicts: # internal/apis/compute/v1alpha1/zz_generated.conversion.go # iri/apis/machine/v1alpha1/api.pb.go
balpert89
reviewed
May 28, 2025
balpert89
reviewed
May 28, 2025
balpert89
reviewed
May 28, 2025
balpert89
reviewed
May 28, 2025
lukasfrank
marked this pull request as ready for review
June 12, 2025 07:06
lukasfrank
force-pushed
the
feat/reservations
branch
from
June 24, 2025 13:08
c4a57fe to
5deff4b
Compare
lukasfrank
added
area/iaas
# Conflicts: # iri/apis/machine/v1alpha1/api.pb.go
lukasfrank
force-pushed
the
feat/reservations
branch
from
July 8, 2025 07:37
47a99e4 to
5ce43e7
Compare
# Conflicts: # broker/machinebroker/server/server_suite_test.go # iri/apis/machine/v1alpha1/api.pb.go # poollet/machinepoollet/api/v1alpha1/common_types.go
lukasfrank
force-pushed
the
feat/reservations
branch
from
September 17, 2025 12:57
98bae53 to
7fe0e69
Compare
lukasfrank
force-pushed
the
feat/reservations
branch
from
September 17, 2025 12:58
7fe0e69 to
1eda5b4
Compare
Rohit-0505
reviewed
Oct 9, 2025
| _, iriReservation := GetSingleMapEntry(srv.Reservations) | ||
|
|
||
| By("inspecting the iri reservation") | ||
| Expect(iriReservation.Metadata.Labels).To(HaveKeyWithValue(fmt.Sprintf("%s%s", machinepoolletv1alpha1.MachineDownwardAPIPrefix, fooDownwardAPILabel), fooAnnotationValue)) |
Contributor
There was a problem hiding this comment.
Suggested change
| Expect(iriReservation.Metadata.Labels).To(HaveKeyWithValue(fmt.Sprintf("%s%s", machinepoolletv1alpha1.MachineDownwardAPIPrefix, fooDownwardAPILabel), fooAnnotationValue)) | |
| Expect(iriReservation.Metadata.Labels).To(HaveKeyWithValue(poolletutils.DownwardAPILabel(machinepoolletv1alpha1.MachineDownwardAPIPrefix, fooDownwardAPILabel), fooAnnotationValue)) |
The above function can be reused here to construct the label.
| iriReservation.Status.State = iri.ReservationState_RESERVATION_STATE_ACCEPTED | ||
| srv.SetReservations([]*testingmachine.FakeReservation{iriReservation}) | ||
|
|
||
| //By("ensuring the ironcore reservation status is pending accepted") |
Contributor
There was a problem hiding this comment.
Can we remove this commented code?
Contributor
|
Can we also put a sample yaml in the |
kasabe28
reviewed
Oct 13, 2025
kasabe28
left a comment
kasabe28
left a comment
Contributor
There was a problem hiding this comment.
We can add docs and gen files also
|
|
||
| const ( | ||
| // ReservationStatePending means the Reservation is being reconciled. | ||
| ReservationStatePending ReservationState = "Pending" |
Contributor
There was a problem hiding this comment.
Bound state is missing as per proposal
Contributor
There was a problem hiding this comment.
all filenames should follow same pattern either starting with machinereservation or reservation considering future enhancements for volume reservation.
| } | ||
|
|
||
| type ReservationPoolStatus struct { | ||
| Name string `json:"ref,omitempty"` |
Contributor
There was a problem hiding this comment.
Suggested change
| Name string `json:"ref,omitempty"` | |
| Name string `json:"name,omitempty"` |
Member
Author
|
Moving this into future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
brokerpoolletapiImplements #1128