Skip to content

Add DownwardAPILabels support for Volume - #1317

Merged
afritzler merged 2 commits into
ironcore-dev:mainfrom
opensovereigncloud:osc/enh/downward-api-labels-support
Jul 9, 2025
Merged

Add DownwardAPILabels support for Volume#1317
afritzler merged 2 commits into
ironcore-dev:mainfrom
opensovereigncloud:osc/enh/downward-api-labels-support

Conversation

@Rohit-0505

Copy link
Copy Markdown
Contributor

Proposed Changes

  • Add downward-api labels support for Volume resource
  • Update the manager.yaml with downward-api-label args
  • Validate the changes with test

Fix:
ref #1316

@Rohit-0505
Rohit-0505 requested a review from a team June 30, 2025 13:01
@Rohit-0505 Rohit-0505 self-assigned this Jun 30, 2025
@github-actions github-actions Bot added size/L enhancement New feature or request labels Jun 30, 2025
@Rohit-0505
Rohit-0505 marked this pull request as draft June 30, 2025 13:08
@opensovereigncloud-user
opensovereigncloud-user force-pushed the osc/enh/downward-api-labels-support branch from 036b8c5 to d2e4b4d Compare June 30, 2025 13:13
@Rohit-0505 Rohit-0505 changed the title Add DownwardAPILables support for Volume Add DownwardAPILabels support for Volume Jul 1, 2025
@Rohit-0505
Rohit-0505 marked this pull request as ready for review July 1, 2025 01:53
@hardikdr hardikdr added the area/iaas Issues related to IronCore IaaS development. label Jul 1, 2025
@hardikdr hardikdr added this to Roadmap Jul 1, 2025
@balpert89

Copy link
Copy Markdown
Contributor

LGTM, also in preparation for the other resources to be enhanced with downward labels.

Comment thread utils/poollet/poollet_utils.go
@opensovereigncloud-user
opensovereigncloud-user force-pushed the osc/enh/downward-api-labels-support branch from 7bb135f to 20bc4e4 Compare July 8, 2025 06:21
@afritzler
afritzler merged commit b9f1460 into ironcore-dev:main Jul 9, 2025
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this to Done in Roadmap Jul 9, 2025
@Rohit-0505
Rohit-0505 deleted the osc/enh/downward-api-labels-support branch July 9, 2025 11:27
@opensovereigncloud-user
opensovereigncloud-user restored the osc/enh/downward-api-labels-support branch July 10, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/iaas Issues related to IronCore IaaS development. enhancement New feature or request size/L

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants