Fix aggregated API server readiness race causing sporadic 503s in envtest suites

[afritzler]

Proposed Changes

Fix aggregated API server readiness race causing sporadic 503s in envtest suites.

Summary by CodeRabbit

• Bug Fixes
  • Improved aggregated API server readiness checks by running real List round-trip probes for each discovered group/version.
  • Updated readiness polling to require multiple consecutive successful probes before marking endpoints ready, reducing false positives.
  • Refined retry behavior to continue through transient API/transport failures, while stopping immediately on non-transient errors.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds an aggregated API serve-readiness probe to envtest after discovery succeeds. It issues List requests for target group/versions, requires sustained success, retries classified transient failures, and stops on non-transient errors.

Changes

Aggregated API Server Serve Readiness

Layer / File(s)	Summary
Invoke serve readiness after discovery utils/envtest/envtest.go	WaitUntilGroupVersionsDiscoverable now calls waitUntilGroupVersionsServe after discovery succeeds, with imports for error inspection.
Poll List serving readiness utils/envtest/envtest.go	waitUntilGroupVersionsServe polls List requests until stable success, selects scheme-registered list objects per group/version, retries transient failures, and aborts on non-transient errors.

Estimated code review effort: 3 (Moderate) | ~25 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only restates the fix and omits the required proposed-change bullets and Fixes # reference.	Add the three Proposed Changes bullets with concrete details and include the related issue number in the Fixes # line.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: fixing envtest aggregated API server readiness races causing sporadic 503s.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/envtest-aggregated-apiserver-readiness

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

utils/envtest/envtest.go (1)

757-767: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Stabilize list target selection. scheme.AllKnownTypes() is map-backed, so firstListTypeForGroupVersion can return a different client.ObjectList kind on different runs. Sort the candidates (for example by Kind) before choosing one.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@utils/envtest/envtest.go` around lines 757 - 767, The list selection in
firstListTypeForGroupVersion is nondeterministic because it iterates
scheme.AllKnownTypes() directly over a map, so the returned client.ObjectList
type can vary between runs. Collect the matching candidates for the requested
schema.GroupVersion, sort them deterministically (for example by GVK.Kind), and
then choose the first matching reflect.Type so the selection is stable.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@utils/envtest/envtest.go`:
- Around line 757-767: The list selection in firstListTypeForGroupVersion is
nondeterministic because it iterates scheme.AllKnownTypes() directly over a map,
so the returned client.ObjectList type can vary between runs. Collect the
matching candidates for the requested schema.GroupVersion, sort them
deterministically (for example by GVK.Kind), and then choose the first matching
reflect.Type so the selection is stable.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 517d2afd-a6ff-4922-aad2-8bc8dbf528e6

📥 Commits

Reviewing files that changed from the base of the PR and between a0e22c5 and 5c84f62.

📒 Files selected for processing (1)

• utils/envtest/envtest.go

[afritzler]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.