Added InterAppCommunication via /dev/iac#315
Open
redbug26 wants to merge 4 commits intoish-app:masterfrom
redbug26:master
Open
Added InterAppCommunication via /dev/iac#315redbug26 wants to merge 4 commits intoish-app:masterfrom redbug26:master
redbug26 wants to merge 4 commits intoish-app:masterfrom
redbug26:master
Conversation
Member
|
Thanks for taking the time to implement this! On first look this seems pretty good. One thing I'd want adjusted is the device number, which is currently 1,99. I would want to reserve an entire major number for iSH devices, and define an API for adding custom entries to the array in fs/dev.c. Looking at the list of allocated major numbers, 240 seems like a good choice, since major numbers from 240 to 254 are reserved for devices with no actual official major number. I'll review this a bit more later. |
Author
|
No problem :) |
saagarjha
reviewed
Feb 16, 2019
Member
saagarjha
left a comment
There was a problem hiding this comment.
Here's a selection of unsolicited review that I thought you might find useful.
This reverts commit 192ec35.
borghetti19
approved these changes
May 1, 2020
shzadakam
approved these changes
Sep 12, 2020
|
What is needed to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You have also to add TARGET_IS_EXTENSION in "Preprocessor Macros" like in this screen
To test:
Could be used to with Shortcut apps via something like