Add missing race select border#516
Merged
Merged
Conversation
There were a few bytes missing from these definitions, causing Rocket Racer Run's border to read from unbound data.
reccmp reportLEGORACERS (LEGORacers.exe)GOLDP (GolDP.dll) |
foxtacles
added a commit
to isledecomp/racers-portable
that referenced
this pull request
Jul 11, 2026
) Merges isledecomp/racers#516 — which restores the 5th VisualStateColor (0x1f1fdaff) and the 25th g_singleRaceVisualStateMap byte (4), both present in the retail binary — and reverts the #16 workaround. ApplyThemeColor returns to the upstream one-liner; index 24 for the special 7th circuit (Rocket Racer Run) is now in bounds, so no ASAN/UBSAN trip. singleraceselectbase.cpp is byte-identical to the decomp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a few bytes from the source executable that were missing from these global definitions, causing Rocket Racer Run's border to read from unbound data.
My guess for why the last color entry looks so different is that someone at High Voltage probably added the values in the wrong order. Causing the border to render as yellow, instead of the red border it has in the 2001 version.